Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 708043002: Disable DRI3 temporarily on Linux desktop. (Closed)

Created:
6 years, 1 month ago by Jorge Lucangeli Obes
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable DRI3 temporarily on Linux desktop. The GPU process is crashing on DRI3-enabled desktop Linux systems. BUG=415681 TEST=On a DRI3 system (Ubuntu 14.10, Intel GPU), GPU process doesn't crash. Committed: https://crrev.com/caa8c58cb570091ea27d8d75a406022ef8e0e82d Cr-Commit-Position: refs/heads/master@{#303269}

Patch Set 1 #

Patch Set 2 : Update comment. #

Total comments: 2

Patch Set 3 : Add block to guarantee scoped_ptr destruction. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/gpu/gpu_main.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Jorge Lucangeli Obes
This is probably the smallest fix we can do.
6 years, 1 month ago (2014-11-07 06:26:32 UTC) #2
mdempsky
lgtm https://chromiumcodereview.appspot.com/708043002/diff/20001/content/gpu/gpu_main.cc File content/gpu/gpu_main.cc (right): https://chromiumcodereview.appspot.com/708043002/diff/20001/content/gpu/gpu_main.cc#newcode220 content/gpu/gpu_main.cc:220: scoped_ptr<base::Environment> env(base::Environment::Create()); nit: Since GpuMain() doesn't return, it ...
6 years, 1 month ago (2014-11-07 06:40:33 UTC) #3
Jorge Lucangeli Obes
I have confirmed this works on 14.10. As soon as I get an el-gee-tee-em from ...
6 years, 1 month ago (2014-11-07 15:53:19 UTC) #4
Jorge Lucangeli Obes
https://chromiumcodereview.appspot.com/708043002/diff/20001/content/gpu/gpu_main.cc File content/gpu/gpu_main.cc (right): https://chromiumcodereview.appspot.com/708043002/diff/20001/content/gpu/gpu_main.cc#newcode220 content/gpu/gpu_main.cc:220: scoped_ptr<base::Environment> env(base::Environment::Create()); On 2014/11/07 06:40:33, mdempsky (Tokyo until Nov ...
6 years, 1 month ago (2014-11-07 15:53:48 UTC) #5
marcheu
On 2014/11/07 15:53:48, Jorge Lucangeli Obes wrote: > https://chromiumcodereview.appspot.com/708043002/diff/20001/content/gpu/gpu_main.cc > File content/gpu/gpu_main.cc (right): > > ...
6 years, 1 month ago (2014-11-07 17:37:18 UTC) #6
Ken Russell (switch to Gerrit)
lgtm
6 years, 1 month ago (2014-11-07 18:13:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708043002/40001
6 years, 1 month ago (2014-11-07 18:18:27 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-07 19:21:10 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 19:21:58 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/caa8c58cb570091ea27d8d75a406022ef8e0e82d
Cr-Commit-Position: refs/heads/master@{#303269}

Powered by Google App Engine
This is Rietveld 408576698