QUIC - track disk cache API calls and failure reasons in separate

QUIC - track disk cache API calls and failure reasons in separate
histograms for disk cache and memory cache.

Added the following new histograms:
  Net.QuicDiskCache.APICall.NoBackend
  Net.QuicDiskCache.APICall.DiskCache
  Net.QuicDiskCache.APICall.MemoryCache
  Net.QuicDiskCache.FailureReason.DiskCache
  Net.QuicDiskCache.FailureReason.MemoryCache
  Net.QuicDiskCache.FailureReason.NoBackend

R=rch@chromium.org, asvitkine@chromium.org

Committed: https://crrev.com/4c887bbe4754776c895a149ed14ab5a6ed29180f
Cr-Commit-Position: refs/heads/master@{#303293}

[ramant (doing other things), 2014-11-07 01:16:39]

rtenneti@chromium.org changed reviewers:
+ asvitkine@chromium.org, rch@chromium.org

[ramant (doing other things), 2014-11-07 01:19:21]

Hi Ryan,
  Added the histograms to separate out disk cache failure reasons for incognito
(MEMORY_CACHE) and non-incognito (DISK_CACHE) to track the disk cache miss rate.
PTAL.

thanks
raman

[Alexei Svitkine (slow), 2014-11-07 16:00:36]

https://codereview.chromium.org/708033002/diff/1/net/http/disk_cache_based_qu...
File net/http/disk_cache_based_quic_server_info.cc (right):

https://codereview.chromium.org/708033002/diff/1/net/http/disk_cache_based_qu...
net/http/disk_cache_based_quic_server_info.cc:363:
UMA_HISTOGRAM_ENUMERATION("Net.QuicDiskCache.FailureReason", failure,
Generally, the practice is to keep the non suffixed histogram log in both cases.

Since that's not what you're doing now, I think it's worth updating the comments
for the base histogram to specify when the base version is logged.
Alternatively, give this case a suffix too.

[ramant (doing other things), 2014-11-07 17:53:04]

https://codereview.chromium.org/708033002/diff/1/net/http/disk_cache_based_qu...
File net/http/disk_cache_based_quic_server_info.cc (right):

https://codereview.chromium.org/708033002/diff/1/net/http/disk_cache_based_qu...
net/http/disk_cache_based_quic_server_info.cc:363:
UMA_HISTOGRAM_ENUMERATION("Net.QuicDiskCache.FailureReason", failure,
On 2014/11/07 16:00:36, Alexei Svitkine wrote:
> Generally, the practice is to keep the non suffixed histogram log in both
cases.
> 
> Since that's not what you're doing now, I think it's worth updating the
comments
> for the base histogram to specify when the base version is logged.
> Alternatively, give this case a suffix too.

Wanted to give it a new suffix, but made the wrong call and didn't do it. Thanks
for the above suggested. Added a new suffix "NoBackend".

Done.

[Ryan Hamilton, 2014-11-07 19:46:03]

lgtm

[Alexei Svitkine (slow), 2014-11-07 19:51:55]

LGTM, thanks!

[ramant (doing other things), 2014-11-07 19:52:26]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-11-07 19:53:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/708033002/20001

[commit-bot: I haz the power, 2014-11-07 19:57:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-07 19:57:23]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/78958)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ramant (doing other things), 2014-11-07 20:15:20]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-11-07 20:15:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/708033002/40001

[commit-bot: I haz the power, 2014-11-07 21:11:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-07 21:12:20]

Patchset 3 (id:??) landed as
https://crrev.com/4c887bbe4754776c895a149ed14ab5a6ed29180f
Cr-Commit-Position: refs/heads/master@{#303293}