Cleanup: Don't check for negative values from EVP_DigestVerifyFinal.

crypto/signature_verifier_openssl.cc

Index: crypto/signature_verifier_openssl.cc
diff --git a/crypto/signature_verifier_openssl.cc b/crypto/signature_verifier_openssl.cc
index 53637ebb60a269eb90f34e69e57d847498a3eef8..0cc57c443a0a4b3272e52b4ab766ebbb0134d46f 100644
--- a/crypto/signature_verifier_openssl.cc
+++ b/crypto/signature_verifier_openssl.cc
@@ -122,8 +122,7 @@ bool SignatureVerifier::VerifyFinal() {
   int rv = EVP_DigestVerifyFinal(verify_context_->ctx.get(),
                                  vector_as_array(&signature_),
                                  signature_.size());
-  // rv is -1 if a DER-encoded ECDSA signature cannot be decoded correctly.
-  DCHECK_GE(rv, -1);
+  DCHECK_GE(rv, 0);

[davidben, 2014/11/11 18:09:43]

Does DCHECK_EQ(!!rv, rv) work, or does it get grumpy about comparing bool and
int?

[eroman, 2014/11/11 18:54:58]

Done.

Works locally, will see if the commit queue likes it!

   Reset();
   return rv == 1;
 }