Cleanup: Don't check for negative values from EVP_DigestVerifyFinal.

Cleanup: Don't check for negative values from EVP_DigestVerifyFinal.

(No longer a possibility in BoringSSL).

Committed: https://crrev.com/5a49bc9eb668725b1c52ce8458eb431b383d8ff7
Cr-Commit-Position: refs/heads/master@{#303700}

[eroman, 2014-11-11 02:25:40]

eroman@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2014-11-11 18:09:43]

lgtm

https://codereview.chromium.org/707973007/diff/1/crypto/signature_verifier_op...
File crypto/signature_verifier_openssl.cc (right):

https://codereview.chromium.org/707973007/diff/1/crypto/signature_verifier_op...
crypto/signature_verifier_openssl.cc:125: DCHECK_GE(rv, 0);
Does DCHECK_EQ(!!rv, rv) work, or does it get grumpy about comparing bool and
int?

[eroman, 2014-11-11 18:54:58]

https://codereview.chromium.org/707973007/diff/1/crypto/signature_verifier_op...
File crypto/signature_verifier_openssl.cc (right):

https://codereview.chromium.org/707973007/diff/1/crypto/signature_verifier_op...
crypto/signature_verifier_openssl.cc:125: DCHECK_GE(rv, 0);
On 2014/11/11 18:09:43, David Benjamin wrote:
> Does DCHECK_EQ(!!rv, rv) work, or does it get grumpy about comparing bool and
> int?

Done.

Works locally, will see if the commit queue likes it!

[eroman, 2014-11-11 18:55:03]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-11-11 18:56:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/707973007/20001

[commit-bot: I haz the power, 2014-11-11 19:58:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-11 19:59:01]

Patchset 2 (id:??) landed as
https://crrev.com/5a49bc9eb668725b1c52ce8458eb431b383d8ff7
Cr-Commit-Position: refs/heads/master@{#303700}