Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 707973004: Files.app: Move lines related with the file type drop down list to DialogActionController. (Closed)

Created:
6 years, 1 month ago by hirono
Modified:
6 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Move lines related with the file type drop down list to DialogActionController. BUG=267281 TEST=None Committed: https://crrev.com/ccc771bae6b154e6f24abbc9604ebb6b89abaabd Cr-Commit-Position: refs/heads/master@{#303448}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fixed. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -65 lines) Patch
M ui/file_manager/file_manager/foreground/js/dialog_action_controller.js View 1 6 chunks +55 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 3 8 chunks +3 lines, -62 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hirono
PTAL the CL? Thanks!
6 years, 1 month ago (2014-11-07 05:29:58 UTC) #2
fukino
https://codereview.chromium.org/707973004/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/707973004/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode11 ui/file_manager/file_manager/foreground/js/file_manager.js:11: var LaunchParam; FileManager explicitly depends on DialogActionController, and DialogActionController ...
6 years, 1 month ago (2014-11-07 10:48:26 UTC) #3
hirono
https://codereview.chromium.org/707973004/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/707973004/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode11 ui/file_manager/file_manager/foreground/js/file_manager.js:11: var LaunchParam; On 2014/11/07 10:48:26, fukino wrote: > FileManager ...
6 years, 1 month ago (2014-11-10 07:11:09 UTC) #4
fukino
On 2014/11/10 07:11:09, hirono wrote: > https://codereview.chromium.org/707973004/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js > File ui/file_manager/file_manager/foreground/js/file_manager.js (right): > > https://codereview.chromium.org/707973004/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode11 > ...
6 years, 1 month ago (2014-11-10 07:40:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707973004/60001
6 years, 1 month ago (2014-11-10 10:51:16 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-10 11:42:13 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 11:42:48 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ccc771bae6b154e6f24abbc9604ebb6b89abaabd
Cr-Commit-Position: refs/heads/master@{#303448}

Powered by Google App Engine
This is Rietveld 408576698