Chromium Code Reviews| Index: cc/debug/rendering_stats.h |
| diff --git a/cc/debug/rendering_stats.h b/cc/debug/rendering_stats.h |
| index 7b1898a9daac5af5bbe41ec1db72f137a0bffbd6..7999a882c304aeb81bf355882bb0817f987b5e3f 100644 |
| --- a/cc/debug/rendering_stats.h |
| +++ b/cc/debug/rendering_stats.h |
| @@ -20,9 +20,6 @@ struct CC_EXPORT RenderingStats { |
| // Stores a sequence of TimeDelta objects. |
| class CC_EXPORT TimeDeltaList { |
| public: |
| - TimeDeltaList(); |
| - ~TimeDeltaList(); |
| - |
| void Append(base::TimeDelta value); |
| void AddToTracedValue(base::debug::TracedValue* list_value) const; |
| @@ -31,51 +28,26 @@ struct CC_EXPORT RenderingStats { |
| base::TimeDelta GetLastTimeDelta() const; |
| private: |
| - std::list<base::TimeDelta> values; |
| + std::vector<base::TimeDelta> values; |
|
vmpstr
2014/11/07 22:41:19
Consider making this type of a change a separate p
|
| }; |
| - struct CC_EXPORT MainThreadRenderingStats { |
| - // Note: when adding new members, please remember to update Add in |
| - // rendering_stats.cc. |
| - |
| - base::TimeDelta paint_time; |
| - int64 painted_pixel_count; |
| - base::TimeDelta record_time; |
| - int64 recorded_pixel_count; |
| - |
| - MainThreadRenderingStats(); |
| - ~MainThreadRenderingStats(); |
| - scoped_refptr<base::debug::ConvertableToTraceFormat> AsTraceableData() |
| - const; |
| - void Add(const MainThreadRenderingStats& other); |
| - }; |
| + RenderingStats(); |
| - struct CC_EXPORT ImplThreadRenderingStats { |
| - // Note: when adding new members, please remember to update Add in |
| - // rendering_stats.cc. |
| + // Note: when adding new members, please remember to update Add in |
| + // rendering_stats.cc. |
| - int64 frame_count; |
| - int64 visible_content_area; |
| - int64 approximated_visible_content_area; |
| - |
| - TimeDeltaList draw_duration; |
| - TimeDeltaList draw_duration_estimate; |
| - TimeDeltaList begin_main_frame_to_commit_duration; |
| - TimeDeltaList begin_main_frame_to_commit_duration_estimate; |
| - TimeDeltaList commit_to_activate_duration; |
| - TimeDeltaList commit_to_activate_duration_estimate; |
| - |
| - ImplThreadRenderingStats(); |
| - ~ImplThreadRenderingStats(); |
| - scoped_refptr<base::debug::ConvertableToTraceFormat> AsTraceableData() |
| - const; |
| - void Add(const ImplThreadRenderingStats& other); |
| - }; |
| + int64 frame_count; |
| + int64 visible_content_area; |
| + int64 approximated_visible_content_area; |
| - MainThreadRenderingStats main_stats; |
| - ImplThreadRenderingStats impl_stats; |
| + TimeDeltaList draw_duration; |
| + TimeDeltaList draw_duration_estimate; |
| + TimeDeltaList begin_main_frame_to_commit_duration; |
| + TimeDeltaList begin_main_frame_to_commit_duration_estimate; |
| + TimeDeltaList commit_to_activate_duration; |
| + TimeDeltaList commit_to_activate_duration_estimate; |
| - // Add fields of |other| to the fields in this structure. |
| + scoped_refptr<base::debug::ConvertableToTraceFormat> AsTraceableData() const; |
| void Add(const RenderingStats& other); |
| }; |