Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 707953004: cleaning up geometry handling in gpu (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@solo_gpu
Project:
skia
Visibility:
Public.

Description

cleaning up geometry handling in gpu BUG=skia: Committed: https://skia.googlesource.com/skia/+/f4e5e3394f9fddeb2e9ddd6ebde0688aec4876b0

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase on master #

Patch Set 3 : rebase try 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -372 lines) Patch
M src/gpu/GrGpu.h View 1 2 6 chunks +10 lines, -89 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 6 chunks +7 lines, -246 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 2 2 chunks +3 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
6 years, 1 month ago (2014-11-07 16:45:54 UTC) #2
bsalomon
lgtm, seems like there is some junk in here to delete. https://codereview.chromium.org/707953004/diff/1/src/gpu/GrGpu.h File src/gpu/GrGpu.h (right): ...
6 years, 1 month ago (2014-11-07 20:04:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707953004/40001
6 years, 1 month ago (2014-11-07 20:48:50 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 20:58:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f4e5e3394f9fddeb2e9ddd6ebde0688aec4876b0

Powered by Google App Engine
This is Rietveld 408576698