Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 707953002: Update ALPN/NPN token from "h2-14" to "h2-15". (Closed)

Created:
6 years, 1 month ago by Bence
Modified:
6 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update ALPN/NPN token from "h2-14" to "h2-15". HTTP/2 draft-15 was published on 2014-10-27. There are no functional changes concerning the features that are currently implemented in Chromium. See https://tools.ietf.org/wg/httpbis/draft-ietf-httpbis-http2/. This change is parallel to the server side change 79349571 by mlavan. Two separate CLs will accompany this change: * Add HTTP_1_1_REQUIRED error code. This will be silently ignored, as Chromium only speaks HTTP/2 to peer that have explicitly acknowledged their support via ALPN or NPN. * https://crrev.com/711563003 BUG=345769 Committed: https://crrev.com/6371af94b25f78f85691e892627a9e88832e2ba0 Cr-Commit-Position: refs/heads/master@{#303150}

Patch Set 1 #

Patch Set 2 : Another occurrence. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M net/http/http_response_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/next_proto.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Bence
Ryan: PTAL. Thanks.
6 years, 1 month ago (2014-11-06 21:59:47 UTC) #2
Ryan Hamilton
I'm sure we talked about this on the call yesterday, and that I missed it, ...
6 years, 1 month ago (2014-11-06 22:06:26 UTC) #3
Bence
On 2014/11/06 22:06:26, Ryan Hamilton wrote: > I'm sure we talked about this on the ...
6 years, 1 month ago (2014-11-07 00:12:23 UTC) #4
Ryan Hamilton
On 2014/11/07 00:12:23, Bence wrote: > On 2014/11/06 22:06:26, Ryan Hamilton wrote: > > I'm ...
6 years, 1 month ago (2014-11-07 00:13:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707953002/20001
6 years, 1 month ago (2014-11-07 00:21:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-07 01:25:17 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 01:26:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6371af94b25f78f85691e892627a9e88832e2ba0
Cr-Commit-Position: refs/heads/master@{#303150}

Powered by Google App Engine
This is Rietveld 408576698