Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 707923003: Allow content property to roundtrip (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years, 1 month ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Allow content property to roundtrip Before this patch the content property parsing did not allow comma separated values but did use comma separated value lists for serialization. This patch changes that behavior to always use space separated lists and adds a test to make sure roundtripping content works. BUG=428445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184993

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Fix test part II #

Patch Set 4 : Add a roundtrip test #

Patch Set 5 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
A LayoutTests/fast/css/content-property-serialization.html View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/content-property-serialization-expected.txt View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/csstext-of-content-string.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/csstext-of-content-string-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
rwlbuis
PTAL
6 years, 1 month ago (2014-11-07 18:41:01 UTC) #2
Timothy Loh
On 2014/11/07 18:41:01, rwlbuis wrote: > PTAL lgtm I would've just written a test like ...
6 years, 1 month ago (2014-11-07 18:46:15 UTC) #3
rwlbuis
On 2014/11/07 18:46:15, Timothy Loh wrote: > On 2014/11/07 18:41:01, rwlbuis wrote: > > PTAL ...
6 years, 1 month ago (2014-11-07 18:49:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707923003/80001
6 years, 1 month ago (2014-11-07 21:49:27 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 22:52:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 184993

Powered by Google App Engine
This is Rietveld 408576698