Add mojo/tools/mopy with paths and version utilities

Add mojo/tools/mopy with paths and version utilities

This consolidates some common mojo python script utilities into
mojo/tools/mopy and updates scripts under mojo/tools to use them.
Currently this has some path manipulation, version querying and python
test running utilities but I expect this to grow over time. A skypy
could also resuse a lot of of this functionality as well.

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/20c2417c3420bccca021c61918f1e9f53444c3e4

[jamesr, 2014-11-07 01:30:31]

Please point out things that I'm doing that differ from idiomatic / best
practices python (even if they're preexisting) - I'm trying to learn the right
way to do things here even if they aren't practical in the near term.  Thanks!

[viettrungluu, 2014-11-07 03:36:39]

viettrungluu@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2014-11-07 03:36:40]

https://codereview.chromium.org/707893005/diff/1/mojo/tools/mopy/paths.py
File mojo/tools/mopy/paths.py (right):

https://codereview.chromium.org/707893005/diff/1/mojo/tools/mopy/paths.py#new...
mojo/tools/mopy/paths.py:1: #!/usr/bin/env python
Delete this line.

https://codereview.chromium.org/707893005/diff/1/mojo/tools/mopy/paths.py#new...
mojo/tools/mopy/paths.py:8: class Paths(object):
A docstring for this class would be nice.

https://codereview.chromium.org/707893005/diff/1/mojo/tools/mopy/paths.py#new...
mojo/tools/mopy/paths.py:13: self.mojo_shell_path = os.path.join(self.src_root,
build_directory,
Is "" really an appropriate default for build_directory?

Maybe you should set its default to None, and only set mojo_shell_path if it
isn't None?

https://codereview.chromium.org/707893005/diff/1/mojo/tools/mopy/version.py
File mojo/tools/mopy/version.py (right):

https://codereview.chromium.org/707893005/diff/1/mojo/tools/mopy/version.py#n...
mojo/tools/mopy/version.py:1: #!/usr/bin/env python
Delete this line.

https://codereview.chromium.org/707893005/diff/1/mojo/tools/mopy/version.py#n...
mojo/tools/mopy/version.py:10: class Version(object):
A docstring would be nice, again.

https://codereview.chromium.org/707893005/diff/1/mojo/tools/run_mojo_python_b...
File mojo/tools/run_mojo_python_bindings_tests.py (right):

https://codereview.chromium.org/707893005/diff/1/mojo/tools/run_mojo_python_b...
mojo/tools/run_mojo_python_bindings_tests.py:13: def __init(self):
Eh?

https://codereview.chromium.org/707893005/diff/1/mojo/tools/upload_shell_bina...
File mojo/tools/upload_shell_binary.py (right):

https://codereview.chromium.org/707893005/diff/1/mojo/tools/upload_shell_bina...
mojo/tools/upload_shell_binary.py:17: paths = Paths(os.path.join("out",
"Release"))
Maybe standard output path generation should be in mopy.paths?

[jamesr, 2014-11-07 18:38:37]

PTAL - everything addressed except for the out/release literal.

>
https://codereview.chromium.org/707893005/diff/1/mojo/tools/upload_shell_bina...
> mojo/tools/upload_shell_binary.py:17: paths = Paths(os.path.join("out",
> "Release"))
> Maybe standard output path generation should be in mopy.paths?

Maybe, but I'm not going to try to fix everything about our python code in one
patch.

[eseidel, 2014-11-07 19:03:48]

lgtm

https://codereview.chromium.org/707893005/diff/20001/mojo/tools/mopy/paths.py
File mojo/tools/mopy/paths.py (right):

https://codereview.chromium.org/707893005/diff/20001/mojo/tools/mopy/paths.py...
mojo/tools/mopy/paths.py:16: self.mojo_shell_path = os.path.join(self.src_root,
build_directory,
Do you want to set this to something in the case no build_dir was passed?  Maybe
None?

[eseidel, 2014-11-07 19:03:49]

lgtm

lgtm

https://codereview.chromium.org/707893005/diff/20001/mojo/tools/mopy/paths.py
File mojo/tools/mopy/paths.py (right):

https://codereview.chromium.org/707893005/diff/20001/mojo/tools/mopy/paths.py...
mojo/tools/mopy/paths.py:16: self.mojo_shell_path = os.path.join(self.src_root,
build_directory,
Do you want to set this to something in the case no build_dir was passed?  Maybe
None?

[jamesr, 2014-11-07 23:41:31]

Committed patchset #2 (id:20001) manually as
20c2417c3420bccca021c61918f1e9f53444c3e4 (presubmit successful).