Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 707853002: Tests to show support for select() API exists (Closed)

Created:
6 years, 1 month ago by Habib Virji
Modified:
6 years, 1 month ago
Reviewers:
keishi, tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Tests to show support for select() API exists select() API is already supported, test cover scenarios for email, number, date, datetime-local, color and file. While support for selection API does not exists. BUG=415391 R=tkent, keishi Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185016

Patch Set 1 #

Total comments: 6

Patch Set 2 : Moved unsupported selection API input type to selection-wrongtype, and corrected input-select-api-s… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -1 line) Patch
A LayoutTests/fast/forms/input-select-api-support.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/input-select-api-support-expected.txt View 1 1 chunk +18 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/selection-wrongtype.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/selection-wrongtype-expected.txt View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Habib Virji
Test added as per comment: https://codereview.chromium.org/596723002/#msg5. Did update the bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=25663, about findings but no ...
6 years, 1 month ago (2014-11-06 14:32:38 UTC) #1
tkent
https://codereview.chromium.org/707853002/diff/1/LayoutTests/fast/forms/input-select-api-support.html File LayoutTests/fast/forms/input-select-api-support.html (right): https://codereview.chromium.org/707853002/diff/1/LayoutTests/fast/forms/input-select-api-support.html#newcode17 LayoutTests/fast/forms/input-select-api-support.html:17: shouldBe('id.select()', ''); This should be |shouldNotThrow('document.getElementById("email").select()');|, and should remove ...
6 years, 1 month ago (2014-11-07 00:22:32 UTC) #2
Habib Virji
Thanks updated as suggested. https://codereview.chromium.org/707853002/diff/1/LayoutTests/fast/forms/input-select-api-support.html File LayoutTests/fast/forms/input-select-api-support.html (right): https://codereview.chromium.org/707853002/diff/1/LayoutTests/fast/forms/input-select-api-support.html#newcode17 LayoutTests/fast/forms/input-select-api-support.html:17: shouldBe('id.select()', ''); On 2014/11/07 00:22:32, ...
6 years, 1 month ago (2014-11-07 13:30:10 UTC) #3
tkent
lgtm
6 years, 1 month ago (2014-11-10 01:50:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707853002/20001
6 years, 1 month ago (2014-11-10 01:51:00 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 02:27:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185016

Powered by Google App Engine
This is Rietveld 408576698