gpu/command_buffer/service/gpu_scheduler.cc - Issue 707833003: gpu: Make sure sync queries complete on service side when calling glFinish.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gpu_scheduler.cc

Issue 707833003: gpu: Make sure sync queries complete on service side when calling glFinish. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wait_if_supported -> did_finish and add some checks to help diagnose these errors Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc ('k') | gpu/command_buffer/service/query_manager.h » ('j') | gpu/command_buffer/service/query_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gpu_scheduler.cc

diff --git a/gpu/command_buffer/service/gpu_scheduler.cc b/gpu/command_buffer/service/gpu_scheduler.cc

index 015d808058582844a8da42758a3300bf658f87ea..e8bf309d3abe3c5b7a7ff4b57aaa3c11a02ab9e1 100644

--- a/gpu/command_buffer/service/gpu_scheduler.cc

+++ b/gpu/command_buffer/service/gpu_scheduler.cc

@@ -170,7 +170,7 @@ bool GpuScheduler::IsScheduled() {

bool GpuScheduler::HasMoreWork() {

return !unschedule_fences_.empty() ||

- (decoder_ && decoder_->ProcessPendingQueries()) ||

+ (decoder_ && decoder_->ProcessPendingQueries(false)) ||

HasMoreIdleWork();

}