Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Side by Side Diff: Source/modules/push_messaging/PushPermissionClient.cpp

Issue 707833002: Plumb Push API permission request through Blink using Frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Delete random whitespace. Similarity=70 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "config.h"
6 #include "modules/push_messaging/PushPermissionClient.h"
7
8 #include "core/dom/Document.h"
9 #include "core/dom/ExecutionContext.h"
10 #include "core/frame/LocalFrame.h"
11
12 namespace blink {
13
14 const char* PushPermissionClient::supplementName()
15 {
16 return "PushPermissionClient";
17 }
18
19 PushPermissionClient* PushPermissionClient::from(ExecutionContext* context)
20 {
21 if (!context->isDocument())
Mike West 2014/11/06 14:21:20 Hrm. Isn't this sort of thing supposed to work ins
Michael van Ouwerkerk 2014/11/06 14:59:46 No, this is exactly the part that cannot work insi
22 return 0;
23
24 const Document* document = toDocument(context);
25 ASSERT(document->frame());
26
27 if (!document->frame()->isLocalFrame())
Mike West 2014/11/06 14:21:20 Can you add a FIXME to support RemoteFrames? (Or p
Michael van Ouwerkerk 2014/11/06 14:59:46 Isn't returning null sufficient? I'm not sure we'd
28 return 0;
29
30 return static_cast<PushPermissionClient*>(WillBeHeapSupplement<LocalFrame>:: from(document->frame(), supplementName()));
31 }
32
33 void providePushPermissionClientTo(LocalFrame& frame, PassOwnPtrWillBeRawPtr<Pus hPermissionClient> client)
34 {
35 frame.provideSupplement(PushPermissionClient::supplementName(), client);
36 }
37
38 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698