Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 707803002: [turbofan] move label generation to code generator (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] move label generation to code generator R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=25201

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -89 lines) Patch
M src/assembler.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/code-generator.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 3 4 4 chunks +24 lines, -26 lines 0 comments Download
M src/compiler/code-generator-impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/instruction.h View 4 chunks +4 lines, -17 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 3 3 chunks +18 lines, -21 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
https://codereview.chromium.org/707803002/diff/20001/src/compiler/code-generator.h File src/compiler/code-generator.h (right): https://codereview.chromium.org/707803002/diff/20001/src/compiler/code-generator.h#newcode124 src/compiler/code-generator.h:124: typedef std::vector<Label> Labels; Nit: ZoneVector<Label>
6 years, 1 month ago (2014-11-06 12:53:31 UTC) #2
dcarney
https://codereview.chromium.org/707803002/diff/20001/src/compiler/code-generator.h File src/compiler/code-generator.h (right): https://codereview.chromium.org/707803002/diff/20001/src/compiler/code-generator.h#newcode124 src/compiler/code-generator.h:124: typedef std::vector<Label> Labels; On 2014/11/06 12:53:31, Benedikt Meurer wrote: ...
6 years, 1 month ago (2014-11-06 13:07:56 UTC) #3
Benedikt Meurer
LGTM
6 years, 1 month ago (2014-11-06 14:40:28 UTC) #4
dcarney
6 years, 1 month ago (2014-11-06 14:59:18 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 25201 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698