Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 7078002: Fix a crash where an index to a modified array wasn't always kept up to date. (Closed)

Created:
9 years, 7 months ago by MAD
Modified:
9 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix a crash where an index to a modified array wasn't always kept up to date. BUG=83924 TEST=Make sure the navigation history is correct. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/browser/tab_contents/navigation_controller.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
MAD
The reviewers list comes from the fact that Maruel@ submitted this code for Yuzo@ a ...
9 years, 7 months ago (2011-05-26 20:19:46 UTC) #1
Avi (use Gerrit)
LGTM
9 years, 7 months ago (2011-05-26 22:00:06 UTC) #2
MAD
On 2011/05/26 22:00:06, Avi wrote: > LGTM Thanks!
9 years, 7 months ago (2011-05-26 22:34:43 UTC) #3
commit-bot: I haz the power
Try job failure for 7078002-1 on linux: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&number=29009
9 years, 7 months ago (2011-05-26 23:04:12 UTC) #4
Yuzo
Hi, I've removed myself from the reviewers because I'm not familiar with the piece of ...
9 years, 7 months ago (2011-05-27 00:23:43 UTC) #5
commit-bot: I haz the power
9 years, 7 months ago (2011-05-27 15:08:34 UTC) #6
Change committed as 87019

Powered by Google App Engine
This is Rietveld 408576698