Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 707713005: Don't require getPropertyCSSValue in animation fill-mode tests (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't require getPropertyCSSValue in animation fill-mode tests As getPropertyCSSValue is no longer web-exposed, we should stop testing it so we can delete the interface. In animation fill-mode tests, it isn't needed as we can just call parseFloat(style.left), as we always return values in the format "123px" and parseFloat drops trailing characters. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M LayoutTests/animations/fill-mode.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/fill-mode-iteration-count-non-integer.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/fill-mode-missing-from-to-keyframes.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/fill-mode-multiple-keyframes.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/fill-mode-removed.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-11-06 21:46:15 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-07 04:21:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707713005/1
6 years, 1 month ago (2014-11-07 16:14:16 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 17:04:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184976

Powered by Google App Engine
This is Rietveld 408576698