Issue 7077: Under construction: Preliminary change to support per...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7077: Under construction: Preliminary change to support per...

Created:
12 years, 2 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Under construction: Preliminary change to support per function constructor stubs.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -59 lines)			Patch
M	src/builtins-ia32.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/codegen-ia32.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/codegen-ia32.cc	View	8 chunks	+45 lines, -35 lines	2 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/macro-assembler-ia32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/macro-assembler-ia32.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+5 lines, -1 line	1 comment	Download
M	src/objects-inl.h	View	2 chunks	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

iposva

12 years, 2 months ago (2008-10-10 13:56:17 UTC) #1

some initial comments

http://codereview.chromium.org/7077/diff/1/9
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/7077/diff/1/9#newcode1235
Line 1235: bool call_constructor,
Please change the bool parameter to an enum {FUNCTION, CONSTRUCTOR} to increase
readability at the call sites.

http://codereview.chromium.org/7077/diff/1/9#newcode2685
Line 2685: CallWithArguments(node->arguments(), true, node->position());
Nice refactoring!

http://codereview.chromium.org/7077/diff/1/6
File src/objects.h (right):

http://codereview.chromium.org/7077/diff/1/6#newcode2498
Line 2498: DECL_ACCESSORS(constructor, Code)
The term constructor is overloaded here. I would prefer to use some different
term like allocator.

Expand Messages | Collapse Messages