Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 7077: Under construction: Preliminary change to support per...

Created:
12 years, 2 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

Under construction: Preliminary change to support per function constructor stubs.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M src/builtins-ia32.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/codegen-ia32.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/codegen-ia32.cc View 8 chunks +45 lines, -35 lines 2 comments Download
M src/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/macro-assembler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 1 comment Download
M src/objects-inl.h View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
iposva
12 years, 2 months ago (2008-10-10 13:56:17 UTC) #1
some initial comments

http://codereview.chromium.org/7077/diff/1/9
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/7077/diff/1/9#newcode1235
Line 1235: bool call_constructor,
Please change the bool parameter to an enum {FUNCTION, CONSTRUCTOR} to increase
readability at the call sites.

http://codereview.chromium.org/7077/diff/1/9#newcode2685
Line 2685: CallWithArguments(node->arguments(), true, node->position());
Nice refactoring!

http://codereview.chromium.org/7077/diff/1/6
File src/objects.h (right):

http://codereview.chromium.org/7077/diff/1/6#newcode2498
Line 2498: DECL_ACCESSORS(constructor, Code)
The term constructor is overloaded here. I would prefer to use some different
term like allocator.

Powered by Google App Engine
This is Rietveld 408576698