Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 707683003: [turbofan] Push TruncateFloat64ToInt32 into phis. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Push TruncateFloat64ToInt32 into phis. TEST=unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
M src/compiler/machine-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 2 chunks +32 lines, -6 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-06 12:19:33 UTC) #2
dcarney
lgtm
6 years, 1 month ago (2014-11-06 12:35:25 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-06 12:38:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698