base/files: Fixed two minor lint warnings.

base/files: Fixed two minor lint warnings.

Two changes identified by "git cl lint":

1. Removed unused <fstream>.
2. DCHECK -> DCHECK_EQ.

Committed: https://crrev.com/d3ca0b0220ec1b4756e640625e0332847a547591
Cr-Commit-Position: refs/heads/master@{#303723}

[cmumford, 2014-11-10 23:11:53]

cmumford@chromium.org changed reviewers:
+ rvargas@chromium.org

[cmumford, 2014-11-10 23:11:53]

PTAL

[rvargas (doing something else), 2014-11-11 18:47:24]

lgtm after nit.

https://codereview.chromium.org/707603003/diff/1/base/files/file_util_posix.cc
File base/files/file_util_posix.cc (right):

https://codereview.chromium.org/707603003/diff/1/base/files/file_util_posix.c...
base/files/file_util_posix.cc:429: DCHECK_EQ(0, mode & ~FILE_PERMISSION_MASK);
nit: swap the order (CHECKs should follow the normal if() flow; (expected,
actual) is a gtest thing).

[cmumford, 2014-11-11 19:26:57]

On 2014/11/11 18:47:24, rvargas wrote:
> lgtm after nit.
> 
> https://codereview.chromium.org/707603003/diff/1/base/files/file_util_posix.cc
> File base/files/file_util_posix.cc (right):
> 
>
https://codereview.chromium.org/707603003/diff/1/base/files/file_util_posix.c...
> base/files/file_util_posix.cc:429: DCHECK_EQ(0, mode & ~FILE_PERMISSION_MASK);
> nit: swap the order (CHECKs should follow the normal if() flow; (expected,
> actual) is a gtest thing).

Isn't that what I had?:

DCHECK_EQ(/*expected=*/0, /*actual=*/mode & ~FILE_PERMISSION_MASK).

Also, grepping the code for DCHECK_EQ/NE/etc. seems to imply that actual is the
first arg. Nonetheless I swapped them as suggested. Thx for the review.

[rvargas (doing something else), 2014-11-11 20:14:55]

On 2014/11/11 19:26:57, cmumford wrote:
> On 2014/11/11 18:47:24, rvargas wrote:
> > lgtm after nit.
> > 
> >
https://codereview.chromium.org/707603003/diff/1/base/files/file_util_posix.cc
> > File base/files/file_util_posix.cc (right):
> > 
> >
>
https://codereview.chromium.org/707603003/diff/1/base/files/file_util_posix.c...
> > base/files/file_util_posix.cc:429: DCHECK_EQ(0, mode &
~FILE_PERMISSION_MASK);
> > nit: swap the order (CHECKs should follow the normal if() flow; (expected,
> > actual) is a gtest thing).
> 
> Isn't that what I had?:
> 
> DCHECK_EQ(/*expected=*/0, /*actual=*/mode & ~FILE_PERMISSION_MASK).
> 
> Also, grepping the code for DCHECK_EQ/NE/etc. seems to imply that actual is
the
> first arg. Nonetheless I swapped them as suggested. Thx for the review.

I have a bad tendency to skip words :(

What I meant to say is that foo(expected, actual) is something that applies to
ASSERT_EQ and EXPECT_EQ [1], but not to DCHECK_EQ: normal run-time checks should
instead read like if statements.

And I agree, this is easy to overlook and lots of places have it wrong.

Thanks.

[1] because the gtest message says "expected: blah", "actual: bar"

[cmumford, 2014-11-11 20:15:54]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-11-11 20:16:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/707603003/20001

[commit-bot: I haz the power, 2014-11-11 21:28:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-11 21:29:09]

Patchset 2 (id:??) landed as
https://crrev.com/d3ca0b0220ec1b4756e640625e0332847a547591
Cr-Commit-Position: refs/heads/master@{#303723}