athena: Use ActivityList where appropriate, and fix AppActivity tests.

athena/content/app_activity_unittest.cc

 /// Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "athena/activity/public/activity_factory.h"
 #include "athena/activity/public/activity_manager.h"
 #include "athena/content/app_activity.h"
 #include "athena/content/app_activity_registry.h"
 #include "athena/content/public/app_registry.h"
 #include "athena/extensions/public/extensions_delegate.h"
@@ skipping 16 matching lines @@
 
 // An identifier for the running apps.
 const char kDummyApp1[] = "aaaaaaa";
 const char kDummyApp2[] = "bbbbbbb";
 
 // A dummy test app activity which works without content / ShellAppWindow.
 class TestAppActivity : public AppActivity {
  public:
   explicit TestAppActivity(const std::string& app_id)
       : AppActivity(app_id),
-        view_(new views::View()),
-        current_state_(ACTIVITY_VISIBLE) {
-    app_activity_registry_ =
-        AppRegistry::Get()->GetAppActivityRegistry(app_id, nullptr);
-    app_activity_registry_->RegisterAppActivity(this);
+        view_(new views::View()) {
   }
   ~TestAppActivity() override {
-    app_activity_registry_->UnregisterAppActivity(this);
   }
 
   AppActivityRegistry* app_activity_registry() {
-    return app_activity_registry_;
-  }
-
-  // Activity:
-  ActivityViewModel* GetActivityViewModel() override { return this; }
-  void SetCurrentState(Activity::ActivityState state) override {
-    current_state_ = state;
-    if (state == ACTIVITY_UNLOADED)
-      app_activity_registry_->Unload();
-  }
-  ActivityState GetCurrentState() override { return current_state_; }
-  bool IsVisible() override { return true; }
-  ActivityMediaState GetMediaState() override {
-    return Activity::ACTIVITY_MEDIA_STATE_NONE;
-  }
-  aura::Window* GetWindow() override {
-    return view_->GetWidget() ? view_->GetWidget()->GetNativeWindow() : nullptr;
+    return AppActivity::app_activity_registry();
   }
 
   // ActivityViewModel:
-  void Init() override {}
-  SkColor GetRepresentativeColor() const override { return 0; }
-  base::string16 GetTitle() const override { return title_; }
-  bool UsesFrame() const override { return true; }
   views::View* GetContentsView() override { return view_; }
-  gfx::ImageSkia GetOverviewModeImage() override { return gfx::ImageSkia(); }
 
  private:
-  // If known the registry which holds all activities for the associated app.
-  AppActivityRegistry* app_activity_registry_;
-
-  // The title of the activity.
-  base::string16 title_;
-
   // Our view.
   views::View* view_;
 
-  // The current state for this activity.
-  ActivityState current_state_;
-
   DISALLOW_COPY_AND_ASSIGN(TestAppActivity);
 };
 
 // An AppContentDelegateClass which we can query for call stats.
 class TestExtensionsDelegate : public ExtensionsDelegate {
  public:
   TestExtensionsDelegate() : unload_called_(0), restart_called_(0) {}
   ~TestExtensionsDelegate() override {}
 
   int unload_called() const { return unload_called_; }
@@ skipping 44 matching lines @@
     AthenaTestBase::SetUp();
     // Create and install our TestAppContentDelegate with instrumentation.
     ExtensionsDelegate::Shutdown();
     // The instance will be deleted by ExtensionsDelegate::Shutdown().
     test_extensions_delegate_ = new TestExtensionsDelegate();
   }
 
   // A function to create an Activity.
   TestAppActivity* CreateAppActivity(const std::string& app_id) {
     TestAppActivity* activity = new TestAppActivity(app_id);
+    activity->SetCurrentState(Activity::ACTIVITY_VISIBLE);
     ActivityManager::Get()->AddActivity(activity);
     return activity;
   }
 
   void DeleteActivity(Activity* activity) {
     Activity::Delete(activity);
     RunAllPendingInMessageLoop();
   }
 
-  // Get the position of the activity in the navigation history.
+  // Get the position of the activity in the navigation history (the position
+  // of the oldest activity is 0).
   int GetActivityPosition(Activity* activity) {
-    aura::Window* window = activity->GetActivityViewModel()->GetContentsView()
-                               ->GetWidget()->GetNativeWindow();
-    aura::Window::Windows windows = activity->GetWindow()->parent()->children();
-    for (size_t i = 0; i < windows.size(); i++) {
-      if (windows[i] == window)
-        return i;
-    }
-    return -1;
+    const ActivityList& activity_list =
+        ActivityManager::Get()->GetActivityList();
+    ActivityList::const_iterator iter =
+        std::find(activity_list.begin(), activity_list.end(), activity);
+    return (iter == activity_list.end()) ? -1
+                                         : (activity_list.end() - iter - 1);
   }
 
   // To avoid interference of the ResourceManager in these AppActivity
   // framework tests, we disable the ResourceManager for some tests.
   // Every use/interference of this function gets explained.
   void DisableResourceManager() {
     ResourceManager::Get()->Pause(true);
   }
 
  protected:
@@ skipping 241 matching lines @@
   // However - the restart in this test framework does not really restart and
   // all objects should be still there..
   EXPECT_EQ(1, AppRegistry::Get()->NumberOfApplications());
   EXPECT_TRUE(app_activity_registry->unloaded_activity_proxy());
   Activity::Delete(app_activity_registry->unloaded_activity_proxy());
   EXPECT_EQ(0, AppRegistry::Get()->NumberOfApplications());
 }
 
 }  // namespace test
 }  // namespace athena