athena: Use ActivityList where appropriate, and fix AppActivity tests.

athena/activity/activity_manager_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "athena/activity/activity_manager_impl.h"
 
 #include <algorithm>
 
 #include "athena/activity/activity_widget_delegate.h"
 #include "athena/activity/public/activity.h"
@@ skipping 51 matching lines @@
     Activity::Delete(activities_.front());
 
   CHECK_EQ(this, instance);
   instance = nullptr;
 }
 
 void ActivityManagerImpl::AddActivity(Activity* activity) {
   CHECK(activities_.end() ==
         std::find(activities_.begin(), activities_.end(), activity));
   activities_.insert(activities_.begin(), activity);
-  views::Widget* widget = CreateWidget(activity);
-  widget->GetNativeView()->AddObserver(this);
-  activity->GetActivityViewModel()->Init();
-
-  FOR_EACH_OBSERVER(ActivityManagerObserver,
-                    observers_,
-                    OnActivityStarted(activity));
+  InitializeActivity(activity);
 }
 
 void ActivityManagerImpl::RemoveActivity(Activity* activity) {
   std::vector<Activity*>::iterator find =
       std::find(activities_.begin(), activities_.end(), activity);
-  DCHECK(find != activities_.end());
-  if (find != activities_.end()) {
-    FOR_EACH_OBSERVER(
-        ActivityManagerObserver, observers_, OnActivityEnding(activity));
-    activities_.erase(find);
-    views::Widget* widget = GetWidget(activity);
-    widget->GetNativeView()->RemoveObserver(this);
-    widget->Close();
-  }
+  if (find == activities_.end())
+    return;
+  activities_.erase(find);
+  UninitializeActivity(activity);
+}
+
+ScopedActivity ActivityManagerImpl::ReplaceActivity(Activity* to_replace,
+                                                    Activity* replace_with) {
+  std::vector<Activity*>::iterator find =
+      std::find(activities_.begin(), activities_.end(), to_replace);
+  if (find == activities_.end())
+    return ScopedActivity();
+  std::replace(find, find + 1, to_replace, replace_with);
+
+  UninitializeActivity(to_replace);
+  InitializeActivity(replace_with);
+  return ScopedActivity(to_replace);
 }
 
 const ActivityList& ActivityManagerImpl::GetActivityList() {
   return activities_;
 }
 
 Activity* ActivityManagerImpl::GetActivityForWindow(aura::Window* window) {
   struct Matcher {
     Matcher(aura::Window* w) : window(w) {}
     bool operator()(Activity* activity) {
       return activity->GetWindow() == window;
     }
     aura::Window* window;
   };
   std::vector<Activity*>::iterator iter =
       std::find_if(activities_.begin(), activities_.end(), Matcher(window));
   return iter != activities_.end() ? *iter : nullptr;
 }
 
 void ActivityManagerImpl::AddObserver(ActivityManagerObserver* observer) {
   observers_.AddObserver(observer);
 }
 
 void ActivityManagerImpl::RemoveObserver(ActivityManagerObserver* observer) {
   observers_.RemoveObserver(observer);
 }
 
+void ActivityManagerImpl::InitializeActivity(Activity* activity) {
+  views::Widget* widget = CreateWidget(activity);
+  widget->GetNativeView()->AddObserver(this);
+  activity->GetActivityViewModel()->Init();
+  FOR_EACH_OBSERVER(ActivityManagerObserver,
+                    observers_,
+                    OnActivityStarted(activity));
+}
+
+void ActivityManagerImpl::UninitializeActivity(Activity* activity) {
+  FOR_EACH_OBSERVER(
+      ActivityManagerObserver, observers_, OnActivityEnding(activity));
+  views::Widget* widget = GetWidget(activity);
+  widget->GetNativeView()->RemoveObserver(this);
+  widget->Close();
+}
+
 void ActivityManagerImpl::OnWindowDestroying(aura::Window* window) {
   Activity* activity = GetActivityForWindow(window);
   if (activity) {
     window->RemoveObserver(this);
     Activity::Delete(activity);
   }
 }
 
 void ActivityManagerImpl::OnWindowActivated(aura::Window* gained_active,
                                             aura::Window* lost_active) {
@@ skipping 25 matching lines @@
   return instance;
 }
 
 void ActivityManager::Shutdown() {
   CHECK(instance);
   delete instance;
 }
 
 
 }  // namespace athena