Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: minidump/minidump_writable.h

Issue 707543002: MinidumpLocationDescriptorListWriter (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_module_crashpad_info_writer_test.cc ('k') | minidump/minidump_writable.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_writable.h
diff --git a/minidump/minidump_writable.h b/minidump/minidump_writable.h
index cfababf95ab105f6b4657d3aa887da828650a0a1..fb34ea2826e6a77b637d827eaefd4a046ec4d0f5 100644
--- a/minidump/minidump_writable.h
+++ b/minidump/minidump_writable.h
@@ -32,6 +32,8 @@ namespace internal {
//! file.
class MinidumpWritable {
public:
+ virtual ~MinidumpWritable();
+
//! \brief Writes an object and all of its children to a minidump file.
//!
//! Use this on the root object of a tree of MinidumpWritable objects,
@@ -134,13 +136,6 @@ class MinidumpWritable {
MinidumpWritable();
- // This doesn’t really need to be virtual because nothing ever deletes a
- // MinidumpWritable* through an interface pointer with that type, and this is
- // guaranteed by being protected. Regardless, the style guide is somewhat
- // insistent.
- // http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Inheritance
- virtual ~MinidumpWritable();
-
//! \brief The state of the object.
State state() const { return state_; }
« no previous file with comments | « minidump/minidump_module_crashpad_info_writer_test.cc ('k') | minidump/minidump_writable.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698