Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: minidump/minidump_module_crashpad_info_writer.h

Issue 707543002: MinidumpLocationDescriptorListWriter (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: minidump/minidump_module_crashpad_info_writer.h
diff --git a/minidump/minidump_module_crashpad_info_writer.h b/minidump/minidump_module_crashpad_info_writer.h
index 2db42a73e3644de06943a8ad54be9c5f88544af7..8fc304c9ccac828cf0f525ff65d0e53f13241ee5 100644
--- a/minidump/minidump_module_crashpad_info_writer.h
+++ b/minidump/minidump_module_crashpad_info_writer.h
@@ -23,6 +23,7 @@
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
#include "minidump/minidump_extensions.h"
+#include "minidump/minidump_location_descriptor_list_writer.h"
#include "minidump/minidump_writable.h"
#include "util/stdlib/pointer_container.h"
@@ -99,7 +100,7 @@ class MinidumpModuleCrashpadInfoWriter final
//! \brief The writer for a MinidumpModuleCrashpadInfoList object in a minidump
//! file, containing a list of MinidumpModuleCrashpadInfo objects.
class MinidumpModuleCrashpadInfoListWriter final
- : public internal::MinidumpWritable {
+ : public MinidumpLocationDescriptorListWriter {
public:
MinidumpModuleCrashpadInfoListWriter();
~MinidumpModuleCrashpadInfoListWriter() override;
@@ -128,18 +129,7 @@ class MinidumpModuleCrashpadInfoListWriter final
//! \note Valid in #kStateMutable.
void AddModule(scoped_ptr<MinidumpModuleCrashpadInfoWriter> module);
- protected:
- // MinidumpWritable:
- bool Freeze() override;
- size_t SizeOfObject() override;
- std::vector<MinidumpWritable*> Children() override;
- bool WriteObject(FileWriterInterface* file_writer) override;
-
private:
- MinidumpModuleCrashpadInfoList module_list_base_;
- PointerVector<MinidumpModuleCrashpadInfoWriter> modules_;
- std::vector<MINIDUMP_LOCATION_DESCRIPTOR> module_location_descriptors_;
-
DISALLOW_COPY_AND_ASSIGN(MinidumpModuleCrashpadInfoListWriter);
};
« no previous file with comments | « minidump/minidump_location_descriptor_list_writer_test.cc ('k') | minidump/minidump_module_crashpad_info_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698