minidump/minidump_module_crashpad_info_writer_test.cc - Issue 707543002: MinidumpLocationDescriptorListWriter

Unified Diff: minidump/minidump_module_crashpad_info_writer_test.cc

Issue 707543002: MinidumpLocationDescriptorListWriter (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Add missing “override” Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_module_crashpad_info_writer_test.cc

diff --git a/minidump/minidump_module_crashpad_info_writer_test.cc b/minidump/minidump_module_crashpad_info_writer_test.cc

index b354a73b16bcd48bd14ebba843e4b8ed8bbfbffb..c256211f2a6a1b18be5f1256174825bf903d9988 100644

--- a/minidump/minidump_module_crashpad_info_writer_test.cc

+++ b/minidump/minidump_module_crashpad_info_writer_test.cc

@@ -79,7 +79,7 @@ TEST(MinidumpModuleCrashpadInfoWriter, EmptyModule) {

const MinidumpModuleCrashpadInfo* module =

MinidumpWritableAtLocationDescriptor<MinidumpModuleCrashpadInfo>(

- file_writer.string(), module_list->modules[0]);

+ file_writer.string(), module_list->children[0]);

ASSERT_TRUE(module);

EXPECT_EQ(MinidumpModuleCrashpadInfo::kVersion, module->version);

@@ -129,7 +129,7 @@ TEST(MinidumpModuleCrashpadInfoWriter, FullModule) {

const MinidumpModuleCrashpadInfo* module =

MinidumpWritableAtLocationDescriptor<MinidumpModuleCrashpadInfo>(

- file_writer.string(), module_list->modules[0]);

+ file_writer.string(), module_list->children[0]);

ASSERT_TRUE(module);

EXPECT_EQ(MinidumpModuleCrashpadInfo::kVersion, module->version);

@@ -217,7 +217,7 @@ TEST(MinidumpModuleCrashpadInfoWriter, ThreeModules) {

const MinidumpModuleCrashpadInfo* module_0 =

MinidumpWritableAtLocationDescriptor<MinidumpModuleCrashpadInfo>(

- file_writer.string(), module_list->modules[0]);

+ file_writer.string(), module_list->children[0]);

ASSERT_TRUE(module_0);

EXPECT_EQ(MinidumpModuleCrashpadInfo::kVersion, module_0->version);

@@ -238,7 +238,7 @@ TEST(MinidumpModuleCrashpadInfoWriter, ThreeModules) {

const MinidumpModuleCrashpadInfo* module_1 =

MinidumpWritableAtLocationDescriptor<MinidumpModuleCrashpadInfo>(

- file_writer.string(), module_list->modules[1]);

+ file_writer.string(), module_list->children[1]);

ASSERT_TRUE(module_1);

EXPECT_EQ(MinidumpModuleCrashpadInfo::kVersion, module_1->version);

@@ -251,7 +251,7 @@ TEST(MinidumpModuleCrashpadInfoWriter, ThreeModules) {

const MinidumpModuleCrashpadInfo* module_2 =

MinidumpWritableAtLocationDescriptor<MinidumpModuleCrashpadInfo>(

- file_writer.string(), module_list->modules[2]);

+ file_writer.string(), module_list->children[2]);

ASSERT_TRUE(module_2);

EXPECT_EQ(MinidumpModuleCrashpadInfo::kVersion, module_2->version);

@@ -319,7 +319,7 @@ TEST(MinidumpModuleCrashpadInfoWriter, InitializeFromSnapshot) {

const MinidumpModuleCrashpadInfo* module_0 =

MinidumpWritableAtLocationDescriptor<MinidumpModuleCrashpadInfo>(

- file_writer.string(), module_list->modules[0]);

+ file_writer.string(), module_list->children[0]);

ASSERT_TRUE(module_0);

EXPECT_EQ(MinidumpModuleCrashpadInfo::kVersion, module_0->version);

@@ -346,7 +346,7 @@ TEST(MinidumpModuleCrashpadInfoWriter, InitializeFromSnapshot) {

const MinidumpModuleCrashpadInfo* module_2 =

MinidumpWritableAtLocationDescriptor<MinidumpModuleCrashpadInfo>(

- file_writer.string(), module_list->modules[1]);

+ file_writer.string(), module_list->children[1]);

ASSERT_TRUE(module_2);

EXPECT_EQ(MinidumpModuleCrashpadInfo::kVersion, module_2->version);

« minidump/minidump_location_descriptor_list_writer.h ('K') | « minidump/minidump_module_crashpad_info_writer.cc ('k') | minidump/minidump_writable.h » ('j') | no next file with comments »