dart2js: Trust type annotations more often with --trust-type-annotation.

pkg/compiler/lib/src/ssa/codegen.dart

Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index fce5372330fa5a595f9723b15dd429d612c0fe95..df440f1e28d7980de814347c221c1788865eaf22 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -2572,8 +2572,9 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
     if (node.isArgumentTypeCheck || node.isReceiverTypeCheck) {
       ClassWorld classWorld = compiler.world;
       // An int check if the input is not int or null, is not
-      // sufficient for doing a argument or receiver check.
-      assert(!node.checkedType.containsOnlyInt(classWorld) ||
+      // sufficient for doing an argument or receiver check.
+      assert(compiler.trustTypeAnnotations ||

[sra1, 2014/11/06 17:47:51]

Does inserting the HTypeKnown during inlining not catch this?
When node.checkInput has dynamic type this leads to the fixnum test for int, (x
| 0) === x, rather than the correct
typeof x == "number" && x == Math.floor(x)

from Sort__dualPivotQuicksort() in swarm
----------
        t2 = J.getInterceptor(comp);
        if (t2.$eq(comp, 0))
          continue;
        if (t2.$lt(comp, 0)) {
---------->
        if (comp === 0)
          continue;
        if (comp !== (comp | 0))    //  
          return comp.$lt();
        if (comp < 0) {
----------

A test for this would be to sort with a compare function:
 
myCompare(a,b) => 1000000000000 * a.compareTo(b).


To be clear: this is an existing bug with the old version of
--trust-type-annotations.  It is what I noticed in the customer code last week.

[floitsch, 2014/11/07 15:50:13]

The problem seems to be that HTypeKnown nodes are removed before we enter
codegen. However, here we try to read the type of the input which, without the
HTypeKnown, isn't "correct" anymore.

+             !node.checkedType.containsOnlyInt(classWorld) ||
              node.checkedInput.isIntegerOrNull(compiler));
       js.Expression test = generateTest(node.checkedInput, node.checkedType);
       js.Block oldContainer = currentContainer;