Issue 707483002: Revert "Parser & internalization fix: ensure no heap allocs during GetString(Handle<String>)."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 707483002: Revert "Parser & internalization fix: ensure no heap allocs during GetString(Handle<String>)." (Closed)

Created:
6 years, 1 month ago by marja

Modified:
6 years, 1 month ago

Reviewers:
marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert "Parser & internalization fix: ensure no heap allocs during GetString(Handle<String>)." This reverts r25155. Reason: breaks webkit unit tests. BUG= TBR=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25159

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -26 lines)			Patch
	M	src/ast-value-factory.h	View		2 chunks	+4 lines, -10 lines	0 comments	Download
	M	src/ast-value-factory.cc	View		4 chunks	+7 lines, -16 lines	0 comments	Download

Total messages: 1 (0 generated)

marja

6 years, 1 month ago (2014-11-05 14:32:10 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 25159 (presubmit successful).