Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 707453002: Reland "Switch telemetry over to use typ to run the unit tests." (Closed)

Created:
6 years, 1 month ago by Paweł Hajdan Jr.
Modified:
6 years, 1 month ago
Reviewers:
dtu, Dirk Pranke, tonyg, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland "Switch telemetry over to use typ to run the unit tests." Original review: https://codereview.chromium.org/659293003 Using typ allows us to run the tests in parallel and share the logic for parsing the results and uploading them to the flakiness dashboard with other python test steps. TBR=dtu@chromium.org, tonyg@chromium.org, nduca@chromium.org, dpranke@chromium.org BUG=402172, 388256 Committed: https://chromium.googlesource.com/chromium/src/+/fc4a811ffe26653019e2213947146a721620e0fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -510 lines) Patch
M tools/perf/run_tests View 1 chunk +14 lines, -9 lines 0 comments Download
M tools/telemetry/PRESUBMIT.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/bootstrap_deps View 1 chunk +17 lines, -30 lines 0 comments Download
M tools/telemetry/run_tests View 1 chunk +14 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/decorators.py View 3 chunks +63 lines, -15 lines 0 comments Download
M tools/telemetry/telemetry/unittest/browser_test_case.py View 1 chunk +33 lines, -12 lines 0 comments Download
D tools/telemetry/telemetry/unittest/json_results.py View 1 chunk +0 lines, -247 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_chromeos_tests.py View 2 chunks +18 lines, -26 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests.py View 4 chunks +114 lines, -143 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests_unittest.py View 2 chunks +18 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fc4a811ffe26653019e2213947146a721620e0fc Cr-Commit-Position: refs/heads/master@{#302795}
6 years, 1 month ago (2014-11-05 14:22:00 UTC) #1
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as fc4a811ffe26653019e2213947146a721620e0fc (presubmit successful).
6 years, 1 month ago (2014-11-05 14:22:40 UTC) #2
Paweł Hajdan Jr.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/708483002/ by phajdan.jr@chromium.org. ...
6 years, 1 month ago (2014-11-05 15:25:24 UTC) #3
Dirk Pranke
6 years, 1 month ago (2014-11-05 15:40:38 UTC) #4
Message was sent while issue was closed.
Hi Paweł,

I appreciate you trying to clean things up, but please do not TBR changes like
this. It's important that the other reviewers and I actually understand what's
going on on the bots and what code is live.

TBR'ing is fine for when the tree is broken and changes need to be reverted, but
this isn't that case and there's no reason for this to land in a hurry.

Powered by Google App Engine
This is Rietveld 408576698