pylint: upgrade to 1.3.1

pylint: upgrade to 1.3.1

The current pylint is very old at this point.  Pull in the latest version
as it supports a lot more features.  Also need to fix the pylint wrapper
to actually update sys.path to use the local modules.

We include the six module since not all bots have it, and it's small.

This will trigger new warnings in files, but they look like legitimate
issues that should be fixed at some point.

BUG=chromium:431514
TEST=ran on some code bases and checked output

[vapier, 2014-11-08 09:33:56]

vapier@chromium.org changed reviewers:
+ chrisha@chromium.org, maruel@chromium.org

[vapier, 2014-11-08 09:33:58]

the majority of this CL is just deleting existing code and dropping in the newer
files.  only changes are in the pylintrc, the README.chromium, and
third_party/pylint.py wrapper.

[M-A Ruel, 2014-11-08 19:28:06]

This is a change with potentially large scale of problems so let's alert
everyone first.

https://codereview.chromium.org/707353002/diff/1/third_party/pylint.py
File third_party/pylint.py (right):

https://codereview.chromium.org/707353002/diff/1/third_party/pylint.py#newcode23
third_party/pylint.py:23: sys.path.insert(0,
os.path.join(os.path.dirname(os.path.abspath(
please create a variable;
THIS_DIR = os.path.dirname(os.path.abspath(__file__))
sys.path.insert(0, os.path.join(THIS_DIR, 'logilab'))

[vapier, 2014-11-08 19:39:16]

https://codereview.chromium.org/707353002/diff/1/third_party/pylint.py
File third_party/pylint.py (right):

https://codereview.chromium.org/707353002/diff/1/third_party/pylint.py#newcode23
third_party/pylint.py:23: sys.path.insert(0,
os.path.join(os.path.dirname(os.path.abspath(
i specifically did not create a variable because that pollutes the module
namespace (or i'd have to turn around and explicitly delete it).  then again,
this isn't a "proper" python module, so i guess that really doesn't matter. 
i'll update it.

[M-A Ruel, 2014-11-08 19:41:41]

https://codereview.chromium.org/707353002/diff/1/third_party/pylint.py
File third_party/pylint.py (right):

https://codereview.chromium.org/707353002/diff/1/third_party/pylint.py#newcode23
third_party/pylint.py:23: sys.path.insert(0,
os.path.join(os.path.dirname(os.path.abspath(
On 2014/11/08 19:39:16, vapier wrote:
> i specifically did not create a variable because that pollutes the module
> namespace (or i'd have to turn around and explicitly delete it).  then again,
> this isn't a "proper" python module, so i guess that really doesn't matter. 
> i'll update it.

Ah ok fine, ignore this then.

[agable, 2014-11-11 18:08:49]

agable@chromium.org changed reviewers:
+ agable@chromium.org

[agable, 2014-11-11 18:08:52]

https://codereview.chromium.org/707353002/diff/10001/pylintrc
File pylintrc (right):

https://codereview.chromium.org/707353002/diff/10001/pylintrc#newcode67
pylintrc:67:
disable=C0103,C0111,C0302,I0010,I0011,R0801,R0901,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0921,R0922,W0122,W0141,W0142,W0402,W0404,W0511,W0603,W0703,W1201,bad-continuation
Please format this with comments so that users know which warnings are being
ignored, and file bugs to fix each class of these warnings at least in the
infrastructure repositories.

I just don't want this to sweep the new warnings under the rug entirely. I'm
fine with disabling the warnings as long as there's an audit trail so people
actually have motivation to go back and fix them in the near future.

[vapier, 2014-11-11 19:50:50]

https://codereview.chromium.org/707353002/diff/10001/pylintrc
File pylintrc (right):

https://codereview.chromium.org/707353002/diff/10001/pylintrc#newcode67
pylintrc:67:
disable=C0103,C0111,C0302,I0010,I0011,R0801,R0901,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0921,R0922,W0122,W0141,W0142,W0402,W0404,W0511,W0603,W0703,W1201,bad-continuation
you've lost me ... there's already a large comment block right above this line
detailing each warning

[agable, 2014-11-12 23:26:58]

https://codereview.chromium.org/707353002/diff/10001/pylintrc
File pylintrc (right):

https://codereview.chromium.org/707353002/diff/10001/pylintrc#newcode67
pylintrc:67:
disable=C0103,C0111,C0302,I0010,I0011,R0801,R0901,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0921,R0922,W0122,W0141,W0142,W0402,W0404,W0511,W0603,W0703,W1201,bad-continuation
On 2014/11/11 at 19:50:50, vapier wrote:
> you've lost me ... there's already a large comment block right above this line
detailing each warning

Sorry, my bad. Was reviewing too fast and thought the list had substantially
changed while the comment hadn't.

[M-A Ruel, 2014-11-15 00:25:58]

lgtm, at worst we'll revert while we clean up downstream projects.

[vapier, 2014-11-15 01:34:38]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2014-11-15 01:35:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/707353002/10001

[commit-bot: I haz the power, 2014-11-15 01:41:08]

Committed patchset #2 (id:10001) as 292954

[Ken Russell (switch to Gerrit), 2014-11-15 02:03:59]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2014-11-15 02:04:00]

This has broken Telemetry's presubmit checks:

https://codereview.chromium.org/726563003/

http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...

** Presubmit ERRORS **
Pylint (437 files) (0.09s) failed
Traceback (most recent call last):
  File "/b/depot_tools/third_party/pylint.py", line 26, in <module>
    from pylint import lint
  File "/b/depot_tools/third_party/pylint/lint.py", line 30, in <module>
    from pylint.checkers import utils #pylint: disable=unused-import
  File "/b/depot_tools/third_party/pylint/checkers/__init__.py", line 45, in
<module>
    from logilab.common.configuration import OptionsProviderMixIn
  File "/b/depot_tools/third_party/logilab/common/__init__.py", line 29, in
<module>
    from six.moves import range
ImportError: No module named six.moves

[vapier, 2014-11-15 02:20:21]

what's the recommended path forward ?  update build/install-build-deps.sh to
install the python six module ?  have the bots include this in their
puppet/whatever setup steps ?  also add the six module to depot_tools'
third_party/ tree ?  i know nothing about the system where this is failing ...

[M-A Ruel, 2014-11-15 14:04:11]

Include six in third_party/

Sent by touching glass
Le 2014-11-14 21:20, <vapier@chromium.org> a écrit :

> what's the recommended path forward ?  update build/install-build-deps.sh
> to
> install the python six module ?  have the bots include this in their
> puppet/whatever setup steps ?  also add the six module to depot_tools'
> third_party/ tree ?  i know nothing about the system where this is failing
> ...
>
> https://codereview.chromium.org/707353002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[vapier, 2014-11-18 04:45:31]

i've added the six module.  turns out it's pretty small.

i verified this worked locally by removing six from my system and pylint still
works (it failed before i included six).

PTAL

[M-A Ruel, 2014-11-18 13:36:06]

https://codereview.chromium.org/707353002/diff/20001/pylintrc
File pylintrc (right):

https://codereview.chromium.org/707353002/diff/20001/pylintrc#newcode64
pylintrc:64:
disable=C0103,C0111,C0302,I0010,I0011,R0801,R0901,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0921,R0922,W0122,W0141,W0142,W0402,W0404,W0511,W0603,W0703,W1201
You had something here before.

https://codereview.chromium.org/707353002/diff/20001/third_party/pylint.py
File third_party/pylint.py (right):

https://codereview.chromium.org/707353002/diff/20001/third_party/pylint.py#ne...
third_party/pylint.py:24: __file__)), 'logilab'))
I see from logilab.<...> in the files, which files require this import path to
be in sys.path?

https://codereview.chromium.org/707353002/diff/20001/third_party/pylint.py#ne...
third_party/pylint.py:26: __file__)), 'six'))
This could be fixed by renaming six.py to __init__.py. I'd actually prefer that.

[M-A Ruel, 2014-11-18 13:36:31]

On 2014/11/18 04:45:31, vapier wrote:
> i've added the six module.  turns out it's pretty small.
> 
> i verified this worked locally by removing six from my system and pylint still
> works (it failed before i included six).
> 
> PTAL

Note that I generally prefer to not reuse previously committed CL.

[vapier, 2014-11-18 18:38:35]

i'll see if i can't figure out how to fight gcl into not re-using things

https://codereview.chromium.org/707353002/diff/20001/pylintrc
File pylintrc (right):

https://codereview.chromium.org/707353002/diff/20001/pylintrc#newcode64
pylintrc:64:
disable=C0103,C0111,C0302,I0010,I0011,R0801,R0901,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0921,R0922,W0122,W0141,W0142,W0402,W0404,W0511,W0603,W0703,W1201
fixed ... gcl+svn is confusing

https://codereview.chromium.org/707353002/diff/20001/third_party/pylint.py
File third_party/pylint.py (right):

https://codereview.chromium.org/707353002/diff/20001/third_party/pylint.py#ne...
third_party/pylint.py:24: __file__)), 'logilab'))
pylint imports astroid directly now

https://codereview.chromium.org/707353002/diff/20001/third_party/pylint.py#ne...
third_party/pylint.py:26: __file__)), 'six'))
done