Source/core/frame/LocalDOMWindow.cpp - Issue 707333003: Update UsageCounter methods to be callable on Frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalDOMWindow.cpp

Issue 707333003: Update UsageCounter methods to be callable on Frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add missing null check Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/LocalDOMWindow.cpp

diff --git a/Source/core/frame/LocalDOMWindow.cpp b/Source/core/frame/LocalDOMWindow.cpp

index ef0b3771b8904be37c2380b0605896c8f7abe083..d75ac641891c40141fdff74490ad5149973bbe7e 100644

--- a/Source/core/frame/LocalDOMWindow.cpp

+++ b/Source/core/frame/LocalDOMWindow.cpp

@@ -1889,7 +1889,7 @@ void LocalDOMWindow::showModalDialog(const String& urlString, const String& dial

if (!canShowModalDialogNow(frame()) || !enteredWindow->allowPopUp())

return;

- UseCounter::countDeprecation(this, UseCounter::ShowModalDialog);

+ UseCounter::countDeprecation(frame(), UseCounter::ShowModalDialog);

WindowFeatures windowFeatures(dialogFeaturesString, screenAvailableRect(frame()->view()));

LocalFrame* dialogFrame = createWindow(urlString, emptyAtom, windowFeatures,

« no previous file with comments | « Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »