Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: Source/core/inspector/AsyncCallStackTracker.h

Issue 707273003: Refactor AsyncCallStackTracker to hide private implementation inner class. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: make class ExecutionContextData forward declaration public Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/inspector/AsyncCallStackTracker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/AsyncCallStackTracker.h
diff --git a/Source/core/inspector/AsyncCallStackTracker.h b/Source/core/inspector/AsyncCallStackTracker.h
index aa43d63d120bf52f864d30724edf96248a2ec183..25449223335307da77bb4872932a12e2e0efe64e 100644
--- a/Source/core/inspector/AsyncCallStackTracker.h
+++ b/Source/core/inspector/AsyncCallStackTracker.h
@@ -32,7 +32,6 @@
#define AsyncCallStackTracker_h
#include "bindings/core/v8/ScriptValue.h"
-#include "core/dom/ContextLifecycleObserver.h"
#include "wtf/Deque.h"
#include "wtf/HashMap.h"
#include "wtf/HashSet.h"
@@ -50,8 +49,9 @@ class ExecutionContextTask;
class MutationObserver;
class XMLHttpRequest;
-class AsyncCallStackTracker final : public NoBaseWillBeGarbageCollectedFinalized<AsyncCallStackTracker> {
+class AsyncCallStackTracker final : public NoBaseWillBeGarbageCollected<AsyncCallStackTracker> {
WTF_MAKE_NONCOPYABLE(AsyncCallStackTracker);
+ DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(AsyncCallStackTracker);
public:
class AsyncCallStack final : public RefCountedWillBeGarbageCollectedFinalized<AsyncCallStack> {
public:
@@ -78,38 +78,6 @@ public:
AsyncCallStackVector m_callStacks;
};
- class ExecutionContextData final : public NoBaseWillBeGarbageCollectedFinalized<ExecutionContextData>, public ContextLifecycleObserver {
- WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
- public:
- ExecutionContextData(AsyncCallStackTracker* tracker, ExecutionContext* executionContext)
- : ContextLifecycleObserver(executionContext)
- , m_circularSequentialID(0)
- , m_tracker(tracker)
- {
- }
-
- virtual void contextDestroyed() override;
-
- int circularSequentialID();
-
- void trace(Visitor*);
-
- private:
- int m_circularSequentialID;
-
- public:
- RawPtrWillBeMember<AsyncCallStackTracker> m_tracker;
- HashSet<int> m_intervalTimerIds;
- WillBeHeapHashMap<int, RefPtrWillBeMember<AsyncCallChain> > m_timerCallChains;
- WillBeHeapHashMap<int, RefPtrWillBeMember<AsyncCallChain> > m_animationFrameCallChains;
- WillBeHeapHashMap<RawPtrWillBeMember<Event>, RefPtrWillBeMember<AsyncCallChain> > m_eventCallChains;
- WillBeHeapHashMap<RawPtrWillBeMember<EventTarget>, RefPtrWillBeMember<AsyncCallChain> > m_xhrCallChains;
- WillBeHeapHashMap<RawPtrWillBeMember<MutationObserver>, RefPtrWillBeMember<AsyncCallChain> > m_mutationObserverCallChains;
- WillBeHeapHashMap<ExecutionContextTask*, RefPtrWillBeMember<AsyncCallChain> > m_executionContextTaskCallChains;
- WillBeHeapHashMap<String, RefPtrWillBeMember<AsyncCallChain> > m_v8AsyncTaskCallChains;
- WillBeHeapHashMap<int, RefPtrWillBeMember<AsyncCallChain> > m_asyncOperationCallChains;
- };
-
AsyncCallStackTracker();
bool isEnabled() const { return m_maxAsyncCallStackDepth; }
@@ -152,6 +120,8 @@ public:
void trace(Visitor*);
+ class ExecutionContextData;
+
private:
void willHandleXHREvent(XMLHttpRequest*, Event*);
« no previous file with comments | « no previous file | Source/core/inspector/AsyncCallStackTracker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698