Refactor AsyncCallStackTracker to hide private implementation inner class.

Refactor AsyncCallStackTracker to hide private implementation inner class.

R=yurys, haraken, keishi, oilpan-reviews

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185141

[yurys, 2014-11-11 12:31:37]

https://codereview.chromium.org/707273003/diff/1/Source/core/inspector/AsyncC...
File Source/core/inspector/AsyncCallStackTracker.cpp (left):

https://codereview.chromium.org/707273003/diff/1/Source/core/inspector/AsyncC...
Source/core/inspector/AsyncCallStackTracker.cpp:457: data =
m_executionContextDataMap.set(context, adoptPtrWillBeNoop(new
AsyncCallStackTracker::ExecutionContextData(this, context)))
Please revert this. The code before your change followed the guideline that
every new allocation is immediately wrapped into adopt*() call and hence stored
in a smart pointer.

https://codereview.chromium.org/707273003/diff/1/Source/core/inspector/AsyncC...
File Source/core/inspector/AsyncCallStackTracker.cpp (right):

https://codereview.chromium.org/707273003/diff/1/Source/core/inspector/AsyncC...
Source/core/inspector/AsyncCallStackTracker.cpp:104: public:
Just move these fields above the private: section header.

https://codereview.chromium.org/707273003/diff/1/Source/core/inspector/AsyncC...
File Source/core/inspector/AsyncCallStackTracker.h (right):

https://codereview.chromium.org/707273003/diff/1/Source/core/inspector/AsyncC...
Source/core/inspector/AsyncCallStackTracker.h:137: // Cannot use
OwnPtrWillBeMember<ExecutionContextData> w/o making ExecutionContextData a
complete public type.
I guess adding explicit destructor and moving its implementation into .cpp file
would make it possible to use OwnPtr as map values here. Alternatively you could
turn m_executionContextDataMap into an OwnPtr

[aandrey, 2014-11-11 13:01:54]

PTAL

[sof, 2014-11-11 13:07:44]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2014-11-11 13:07:45]

https://codereview.chromium.org/707273003/diff/2/Source/core/inspector/AsyncC...
File Source/core/inspector/AsyncCallStackTracker.h (right):

https://codereview.chromium.org/707273003/diff/2/Source/core/inspector/AsyncC...
Source/core/inspector/AsyncCallStackTracker.h:52: class AsyncCallStackTracker
final : public NoBaseWillBeGarbageCollectedFinalized<AsyncCallStackTracker> {
If you can avoid a destructor (it looks like you can), then make this
NoBaseWillBeGarbageCollected<...> instead.

[aandrey, 2014-11-11 13:15:02]

https://codereview.chromium.org/707273003/diff/2/Source/core/inspector/AsyncC...
File Source/core/inspector/AsyncCallStackTracker.h (right):

https://codereview.chromium.org/707273003/diff/2/Source/core/inspector/AsyncC...
Source/core/inspector/AsyncCallStackTracker.h:52: class AsyncCallStackTracker
final : public NoBaseWillBeGarbageCollectedFinalized<AsyncCallStackTracker> {
On 2014/11/11 13:07:44, sof wrote:
> If you can avoid a destructor (it looks like you can), then make this
> NoBaseWillBeGarbageCollected<...> instead.

Done.

[sof, 2014-11-11 13:18:47]

lgtm

[haraken, 2014-11-11 13:20:31]

LGTM

[aandrey, 2014-11-11 17:32:52]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-11-11 17:33:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/707273003/50001

[commit-bot: I haz the power, 2014-11-11 19:41:13]

Committed patchset #4 (id:50001) as 185141