Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 707233006: Remove scrollbar width/height computations from layout. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove scrollbar width/height computations from layout. Scrollbars never take up layout space or participate in hit-testing. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5a1876e30d40d43bb5ef0d4c30c92638382e25a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -160 lines) Patch
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 3 chunks +2 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 14 chunks +15 lines, -80 lines 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.cpp View 10 chunks +7 lines, -25 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 3 chunks +2 lines, -23 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
6 years, 1 month ago (2014-11-08 01:16:28 UTC) #2
ojan
6 years, 1 month ago (2014-11-08 01:54:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a1876e30d40d43bb5ef0d4c30c92638382e25a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698