Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 707233003: Refresh Public Suffix List to the latest version (Closed)

Created:
6 years, 1 month ago by Ryan Sleevi
Modified:
6 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refresh Public Suffix List to the latest version This updates to the following revision: 0650c4edb139 2014-11-04 01:51 -0500 It includes changes from revision f2c25ddbd1cf (2014-09-02 07:27 +0200) to revision 0650c4edb139 (2014-11-04 01:51 -0500), listed at http://hg.mozilla.org/mozilla-central/log/0650c4edb139/netwerk/dns/effective_tld_names.dat R=pkasting@chromium.org BUG=37436 Committed: https://crrev.com/0fef34d4f5b2e5cd138cc9696f5f189c8c8c2384 Cr-Commit-Position: refs/heads/master@{#303273}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -71 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.dat View 71 chunks +311 lines, -53 lines 2 comments Download
M net/base/registry_controlled_domains/effective_tld_names.gperf View 89 chunks +132 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Ryan Sleevi
pkasting: PTAL for a hopefully easy rubber stamp - no big changes, and upstream has ...
6 years, 1 month ago (2014-11-07 18:13:08 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/707233003/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/707233003/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode9040 net/base/registry_controlled_domains/effective_tld_names.dat:9040: art.pl Huh. I don't know whether these being ...
6 years, 1 month ago (2014-11-07 18:49:33 UTC) #2
Ryan Sleevi
https://codereview.chromium.org/707233003/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/707233003/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode9040 net/base/registry_controlled_domains/effective_tld_names.dat:9040: art.pl On 2014/11/07 18:49:33, Peter Kasting wrote: > Huh. ...
6 years, 1 month ago (2014-11-07 18:51:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707233003/1
6 years, 1 month ago (2014-11-07 18:52:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 19:46:49 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 19:47:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fef34d4f5b2e5cd138cc9696f5f189c8c8c2384
Cr-Commit-Position: refs/heads/master@{#303273}

Powered by Google App Engine
This is Rietveld 408576698