Source/bindings/core/v8/ScriptPreprocessor.cpp - Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptPreprocessor.cpp

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptPreprocessor.h ('K') | « Source/bindings/core/v8/ScriptPreprocessor.h ('k') | Source/bindings/core/v8/ScriptPromisePropertyTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/ScriptPreprocessor.cpp

diff --git a/Source/bindings/core/v8/ScriptPreprocessor.cpp b/Source/bindings/core/v8/ScriptPreprocessor.cpp

index 4d1152068369c6b9724fd2062d8243dbd495fa8b..7cea53e3d13d1f0e29dbf76f02dc32b27d58afb6 100644

--- a/Source/bindings/core/v8/ScriptPreprocessor.cpp

+++ b/Source/bindings/core/v8/ScriptPreprocessor.cpp

@@ -44,10 +44,10 @@

namespace blink {

-ScriptPreprocessor::ScriptPreprocessor(const ScriptSourceCode& preprocessorSourceCode, LocalFrame* frame)

+ScriptPreprocessor::ScriptPreprocessor(const ScriptSourceCode& preprocessorSourceCode, LocalFrame* frame, v8::Isolate* isolate)

: m_isPreprocessing(false)

{

- RefPtr<DOMWrapperWorld> world = DOMWrapperWorld::ensureIsolatedWorld(ScriptPreprocessorIsolatedWorldId, DOMWrapperWorld::mainWorldExtensionGroup);

+ RefPtr<DOMWrapperWorld> world = DOMWrapperWorld::ensureIsolatedWorld(isolate, ScriptPreprocessorIsolatedWorldId, DOMWrapperWorld::mainWorldExtensionGroup);

m_scriptState = ScriptState::from(toV8Context(frame, *world));

v8::HandleScope handleScope(m_scriptState->isolate());