Source/bindings/core/v8/DOMDataStore.h - Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/DOMDataStore.h

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/DOMDataStore.h

diff --git a/Source/bindings/core/v8/DOMDataStore.h b/Source/bindings/core/v8/DOMDataStore.h

index dc61d83188e7169ea4a7c68cdbd7b8e1ed5c5ff5..2d6d11b0e504c685502673e8e34a4f70f4a6678f 100644

--- a/Source/bindings/core/v8/DOMDataStore.h

+++ b/Source/bindings/core/v8/DOMDataStore.h

@@ -46,9 +46,9 @@ class Node;

class DOMDataStore {

WTF_MAKE_NONCOPYABLE(DOMDataStore);

public:

- explicit DOMDataStore(bool isMainWorld)

+ DOMDataStore(v8::Isolate* isolate, bool isMainWorld)

: m_isMainWorld(isMainWorld)

- , m_wrapperMap(v8::Isolate::GetCurrent()) { }

+ , m_wrapperMap(isolate) { }

~DOMDataStore()

{

// We never actually destruct the main world's DOMDataStore.