Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: Source/bindings/core/v8/PageScriptDebugServer.cpp

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 Google Inc. All rights reserved. 2 * Copyright (c) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 { 271 {
272 ASSERT(frame); 272 ASSERT(frame);
273 273
274 if (!m_preprocessorSourceCode || !frame->page() || isCreatingPreprocessor) 274 if (!m_preprocessorSourceCode || !frame->page() || isCreatingPreprocessor)
275 return false; 275 return false;
276 276
277 // We delay the creation of the preprocessor until just before the first JS from the 277 // We delay the creation of the preprocessor until just before the first JS from the
278 // Web page to ensure that the debugger's console initialization code has co mpleted. 278 // Web page to ensure that the debugger's console initialization code has co mpleted.
279 if (!m_scriptPreprocessor) { 279 if (!m_scriptPreprocessor) {
280 TemporaryChange<bool> isPreprocessing(isCreatingPreprocessor, true); 280 TemporaryChange<bool> isPreprocessing(isCreatingPreprocessor, true);
281 m_scriptPreprocessor = adoptPtr(new ScriptPreprocessor(*m_preprocessorSo urceCode.get(), frame)); 281 m_scriptPreprocessor = adoptPtr(new ScriptPreprocessor(*m_preprocessorSo urceCode.get(), frame, m_isolate));
282 } 282 }
283 283
284 if (m_scriptPreprocessor->isValid()) 284 if (m_scriptPreprocessor->isValid())
285 return true; 285 return true;
286 286
287 m_scriptPreprocessor.clear(); 287 m_scriptPreprocessor.clear();
288 // Don't retry the compile if we fail one time. 288 // Don't retry the compile if we fail one time.
289 m_preprocessorSourceCode.clear(); 289 m_preprocessorSourceCode.clear();
290 return false; 290 return false;
291 } 291 }
(...skipping 27 matching lines...) Expand all
319 UseCounter::muteForInspector(); 319 UseCounter::muteForInspector();
320 } 320 }
321 321
322 void PageScriptDebugServer::unmuteWarningsAndDeprecations() 322 void PageScriptDebugServer::unmuteWarningsAndDeprecations()
323 { 323 {
324 FrameConsole::unmute(); 324 FrameConsole::unmute();
325 UseCounter::unmuteForInspector(); 325 UseCounter::unmuteForInspector();
326 } 326 }
327 327
328 } // namespace blink 328 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698