Chromium Code Reviews Chromium Code Reviews
Issue 707193004:
Plugin Power Saver: Collect size histogram on Flash Plugins users click. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 431df736a479abd4c5c4f327598d13aa12d6b6fd..bb0f42258e5ebeb4de10adb3bd7ca11a83081634 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -25085,6 +25085,29 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Plugin.FlashClickSizeAspectRatio"> |
| + <owner>tommycli@chromium.org</owner> |
| + <summary>Aspect ratio of Flash plugins users click at least once.</summary> |
|
groby-ooo-7-16
2014/11/07 21:57:44
Should probably explain what the values mean. (I.e
tommycli
2014/11/07 22:46:38
Done.
|
| +</histogram> |
| + |
| +<histogram name="Plugin.FlashClickSizeHeight" units="pixels"> |
| + <owner>tommycli@chromium.org</owner> |
| + <summary>Height of Flash plugins users click at least once.</summary> |
| +</histogram> |
| + |
| +<histogram name="Plugin.FlashClickSizeWidth" units="pixels"> |
| + <owner>tommycli@chromium.org</owner> |
| + <summary>Width of Flash plugins users click at least once.</summary> |
| +</histogram> |
| + |
| +<histogram name="Plugin.FlashInstanceSize" enum="FlashInstanceSize"> |
|
groby-ooo-7-16
2014/11/07 21:57:44
Technically, the name should reflect this is about
tommycli
2014/11/07 22:46:38
Done.
|
| + <owner>tommycli@chromium.org</owner> |
| + <summary> |
| + Collects the sizes of all loaded Flash plugin instances. This is for |
| + determining the prevalence of tiny flash plugin instances. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Plugin.FlashNavigateUsage" enum="FlashNavigateUsageType"> |
| <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| <summary>Record usage of PPB_Flash.Navigate() Pepper API.</summary> |
| @@ -45844,6 +45867,13 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| <int value="20" label=".log"/> |
| </enum> |
| +<enum name="FlashInstanceSize" type="int"> |
| + <int value="0" label="1x1 or smaller"/> |
| + <int value="1" label="5x5 or smaller"/> |
| + <int value="2" label="10x10 or smaller"/> |
| + <int value="3" label="Large"/> |
| +</enum> |
| + |
| <enum name="FlashNavigateUsageType" type="int"> |
| <int value="0" label="Rejected because of Authorization header."/> |
| <int value="1" label="Rejected because of Cache-Control header."/> |
