chrome/browser/prerender/prerender_tab_helper.h - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_tab_helper.h

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests, respond to review comments, cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/prerender/prerender_tab_helper.cc » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prerender/prerender_tab_helper.h

diff --git a/chrome/browser/prerender/prerender_tab_helper.h b/chrome/browser/prerender/prerender_tab_helper.h

index 397ca09864d3901dbf307fe4d10d8f2c79c26b4e..ad9cb61f2623cc7c81d1bd5645f0d9040e6e6eb5 100644

--- a/chrome/browser/prerender/prerender_tab_helper.h

+++ b/chrome/browser/prerender/prerender_tab_helper.h

@@ -44,10 +44,6 @@ class PrerenderTabHelper

EVENT_MAX_VALUE

};

- static void CreateForWebContentsWithPasswordManager(

- content::WebContents* web_contents,

- password_manager::PasswordManager* password_manager);

~PrerenderTabHelper() override;

// content::WebContentsObserver implementation.

@@ -79,8 +75,7 @@ class PrerenderTabHelper

void WouldHavePrerenderedNextLoad(Origin origin);

private:

- PrerenderTabHelper(content::WebContents* web_contents,

- password_manager::PasswordManager* password_manager);

+ explicit PrerenderTabHelper(content::WebContents* web_contents);

friend class content::WebContentsUserData<PrerenderTabHelper>;

void RecordEvent(Event event) const;