Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mem leak Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.h
diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h
index c89e6e537ad2ae1b8a4296acef0c45da6e9bae62..bf0fd639823b065e3ad5cfc81121f5efe63fc7b6 100644
--- a/components/password_manager/core/browser/password_manager.h
+++ b/components/password_manager/core/browser/password_manager.h
@@ -63,7 +63,8 @@ class PasswordManager : public LoginModel {
// Called by a PasswordFormManager when it decides a form can be autofilled
// on the page.
- virtual void Autofill(const autofill::PasswordForm& form_for_autofill,
+ virtual void Autofill(password_manager::PasswordManagerDriver* driver,
+ const autofill::PasswordForm& form_for_autofill,
const autofill::PasswordFormMap& best_matches,
const autofill::PasswordForm& preferred_match,
bool wait_for_username) const;
@@ -73,7 +74,9 @@ class PasswordManager : public LoginModel {
void RemoveObserver(LoginModelObserver* observer) override;
// Mark this form as having a generated password.
- void SetFormHasGeneratedPassword(const autofill::PasswordForm& form);
+ void SetFormHasGeneratedPassword(
+ password_manager::PasswordManagerDriver* driver,
+ const autofill::PasswordForm& form);
// TODO(isherman): This should not be public, but is currently being used by
// the LoginPrompt code.
@@ -86,16 +89,18 @@ class PasswordManager : public LoginModel {
void DidNavigateMainFrame(bool is_in_page);
// Handles password forms being parsed.
- void OnPasswordFormsParsed(
- const std::vector<autofill::PasswordForm>& forms);
+ void OnPasswordFormsParsed(password_manager::PasswordManagerDriver* driver,
+ const std::vector<autofill::PasswordForm>& forms);
// Handles password forms being rendered.
void OnPasswordFormsRendered(
+ password_manager::PasswordManagerDriver* driver,
const std::vector<autofill::PasswordForm>& visible_forms,
bool did_stop_loading);
// Handles a password form being submitted.
virtual void OnPasswordFormSubmitted(
+ password_manager::PasswordManagerDriver* driver,
const autofill::PasswordForm& password_form);
PasswordManagerClient* client() { return client_; }
@@ -147,6 +152,7 @@ class PasswordManager : public LoginModel {
// Checks for every from in |forms| whether |pending_login_managers_| already
// contain a manager for that form. If not, adds a manager for each such form.
void CreatePendingLoginManagers(
+ password_manager::PasswordManagerDriver* driver,
const std::vector<autofill::PasswordForm>& forms);
// Note about how a PasswordFormManager can transition from
@@ -176,9 +182,6 @@ class PasswordManager : public LoginModel {
// The embedder-level client. Must outlive this class.
PasswordManagerClient* const client_;
- // The platform-level driver. Must outlive this class.
- PasswordManagerDriver* const driver_;
-
// Set to false to disable password saving (will no longer ask if you
// want to save passwords but will continue to fill passwords).
BooleanPrefMember saving_passwords_enabled_;

Powered by Google App Engine
This is Rietveld 408576698