components/password_manager/core/browser/password_autofill_manager_unittest.cc - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager_unittest.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mem leak Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_autofill_manager.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_autofill_manager_unittest.cc b/components/password_manager/core/browser/password_autofill_manager_unittest.cc

index e8b5bd20d2c0b3ed205c418953306700290fce84..374081ebffe3bfe4719a184983d0e2229a564814 100644

--- a/components/password_manager/core/browser/password_autofill_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_autofill_manager_unittest.cc

@@ -46,8 +46,6 @@ class MockPasswordManagerDriver : public StubPasswordManagerDriver {

class TestPasswordManagerClient : public StubPasswordManagerClient {

public:

- PasswordManagerDriver* GetDriver() override { return &driver_; }

MockPasswordManagerDriver* mock_driver() { return &driver_; }

private:

@@ -90,10 +88,10 @@ class PasswordAutofillManagerTest : public testing::Test {

}

void InitializePasswordAutofillManager(

- PasswordManagerClient* client,

+ TestPasswordManagerClient* client,

autofill::AutofillClient* autofill_client) {

- password_autofill_manager_.reset(

- new PasswordAutofillManager(client, autofill_client));

+ password_autofill_manager_.reset(new PasswordAutofillManager(

+ client, client->mock_driver(), autofill_client));

password_autofill_manager_->OnAddPasswordFormMapping(fill_data_id_,

fill_data_);

}