Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: components/password_manager/core/browser/password_autofill_manager.h

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mem leak Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_autofill_manager.h
diff --git a/components/password_manager/core/browser/password_autofill_manager.h b/components/password_manager/core/browser/password_autofill_manager.h
index 4ad14b9b21b767031a710a82f24f8a5964a57b7f..4da59ef9836d45a193449ed9f996378c6de9d812 100644
--- a/components/password_manager/core/browser/password_autofill_manager.h
+++ b/components/password_manager/core/browser/password_autofill_manager.h
@@ -20,11 +20,13 @@ class RectF;
namespace password_manager {
class PasswordManagerClient;
+class PasswordManagerDriver;
// This class is responsible for filling password forms.
class PasswordAutofillManager : public autofill::AutofillPopupDelegate {
public:
PasswordAutofillManager(PasswordManagerClient* password_manager_client,
+ PasswordManagerDriver* password_manager_driver,
autofill::AutofillClient* autofill_client);
virtual ~PasswordAutofillManager();
@@ -92,6 +94,9 @@ class PasswordAutofillManager : public autofill::AutofillPopupDelegate {
// Provides embedder-level operations on passwords. Must outlive |this|.
PasswordManagerClient* const password_manager_client_; // weak
+ // The driver that owns |this|.
+ PasswordManagerDriver* password_manager_driver_;
+
autofill::AutofillClient* const autofill_client_; // weak
base::WeakPtrFactory<PasswordAutofillManager> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698