components/autofill/content/renderer/page_click_tracker.h - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/page_click_tracker.h

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mem leak Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/autofill_agent.cc ('k') | components/autofill/content/renderer/page_click_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/page_click_tracker.h

diff --git a/components/autofill/content/renderer/page_click_tracker.h b/components/autofill/content/renderer/page_click_tracker.h

index 7849b902344b257247d68071297992bdb238f9a7..0bcc0f6299b1a06f21bf5dbe248c311f0c25a834 100644

--- a/components/autofill/content/renderer/page_click_tracker.h

+++ b/components/autofill/content/renderer/page_click_tracker.h

@@ -23,7 +23,8 @@ class PageClickListener;

// This is useful for password/form autofill where we want to trigger a

// suggestion popup when a text input is clicked.

-// There is one PageClickTracker per RenderView.

+// There is one PageClickTracker per AutofillAgent.

+// TODO(estade): migrate to content::RenderFrameObserver.

class PageClickTracker : public content::RenderViewObserver {

public:

// The |listener| will be notified when an element is clicked. It must

@@ -34,6 +35,7 @@ class PageClickTracker : public content::RenderViewObserver {

private:

// RenderView::Observer implementation.

+ void OnDestruct() override;

void DidHandleMouseEvent(const blink::WebMouseEvent& event) override;

void DidHandleGestureEvent(const blink::WebGestureEvent& event) override;

void FocusedNodeChanged(const blink::WebNode& node) override;