Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2984)

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mem leak Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
index 05f7f9881bb3780ca1067e6f44ad403c3e057f2f..7c55fabad16820a73c643fa342d674101406e972 100644
--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
@@ -44,6 +44,7 @@ PasswordGenerationPopupControllerImpl::GetOrCreate(
const PasswordForm& form,
int max_length,
password_manager::PasswordManager* password_manager,
+ password_manager::PasswordManagerDriver* driver,
PasswordGenerationPopupObserver* observer,
content::WebContents* web_contents,
gfx::NativeView container_view) {
@@ -59,13 +60,8 @@ PasswordGenerationPopupControllerImpl::GetOrCreate(
PasswordGenerationPopupControllerImpl* controller =
new PasswordGenerationPopupControllerImpl(
- bounds,
- form,
- max_length,
- password_manager,
- observer,
- web_contents,
- container_view);
+ bounds, form, max_length, password_manager, driver, observer,
+ web_contents, container_view);
return controller->GetWeakPtr();
}
@@ -74,12 +70,14 @@ PasswordGenerationPopupControllerImpl::PasswordGenerationPopupControllerImpl(
const PasswordForm& form,
int max_length,
password_manager::PasswordManager* password_manager,
+ password_manager::PasswordManagerDriver* driver,
PasswordGenerationPopupObserver* observer,
content::WebContents* web_contents,
gfx::NativeView container_view)
: view_(NULL),
form_(form),
password_manager_(password_manager),
+ driver_(driver),
observer_(observer),
generator_(new PasswordGenerator(max_length)),
controller_common_(bounds, container_view, web_contents),
@@ -155,7 +153,7 @@ void PasswordGenerationPopupControllerImpl::PasswordAccepted() {
new AutofillMsg_GeneratedPasswordAccepted(
web_contents()->GetRenderViewHost()->GetRoutingID(),
current_password_));
- password_manager_->SetFormHasGeneratedPassword(form_);
+ password_manager_->SetFormHasGeneratedPassword(driver_, form_);
Hide();
}

Powered by Google App Engine
This is Rietveld 408576698