chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mem leak Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller_impl.cc ('k') | chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

index 3d5a686b7044b4fd4b98f2728815db589c2a5e68..9331f1ce35ad949448ed7fccaf542b00d19cf469 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "components/autofill/content/browser/content_autofill_driver.h"

+#include "components/autofill/content/browser/content_autofill_driver_factory.h"

#include "components/autofill/core/browser/autofill_manager.h"

#include "components/autofill/core/browser/test_autofill_external_delegate.h"

#include "content/public/browser/web_contents.h"

@@ -78,7 +79,8 @@ class AutofillPopupControllerBrowserTest

Observe(web_contents);

ContentAutofillDriver* driver =

- ContentAutofillDriver::FromWebContents(web_contents);

+ ContentAutofillDriverFactory::FromWebContents(web_contents)

+ ->DriverForFrame(web_contents->GetMainFrame());

autofill_external_delegate_.reset(

new TestAutofillExternalDelegate(

web_contents,