chrome/browser/autofill/form_structure_browsertest.cc - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/form_structure_browsertest.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mem leak Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/content_autofill_driver_browsertest.cc ('k') | chrome/browser/password_manager/chrome_password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/form_structure_browsertest.cc

diff --git a/chrome/browser/autofill/form_structure_browsertest.cc b/chrome/browser/autofill/form_structure_browsertest.cc

index df8a9c3ad26111c0d35d505c10bc0a6f509ca8ed..ea53d05c4449f6c3f89a2e10f48826dd3920f4d5 100644

--- a/chrome/browser/autofill/form_structure_browsertest.cc

+++ b/chrome/browser/autofill/form_structure_browsertest.cc

@@ -14,6 +14,7 @@

#include "chrome/test/base/in_process_browser_test.h"

#include "chrome/test/base/ui_test_utils.h"

#include "components/autofill/content/browser/content_autofill_driver.h"

+#include "components/autofill/content/browser/content_autofill_driver_factory.h"

#include "components/autofill/core/browser/autofill_manager.h"

#include "components/autofill/core/browser/data_driven_test.h"

#include "components/autofill/core/browser/form_structure.h"

@@ -71,9 +72,11 @@ void FormStructureBrowserTest::GenerateResults(const std::string& input,

ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(),

HTMLToDataURI(input)));

+ content::WebContents* web_contents =

+ browser()->tab_strip_model()->GetActiveWebContents();

ContentAutofillDriver* autofill_driver =

- ContentAutofillDriver::FromWebContents(

- browser()->tab_strip_model()->GetActiveWebContents());

+ ContentAutofillDriverFactory::FromWebContents(web_contents)

+ ->DriverForFrame(web_contents->GetMainFrame());

ASSERT_NE(static_cast<ContentAutofillDriver*>(NULL), autofill_driver);

AutofillManager* autofill_manager = autofill_driver->autofill_manager();

ASSERT_NE(static_cast<AutofillManager*>(NULL), autofill_manager);