Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3328)

Unified Diff: android_webview/renderer/aw_content_renderer_client.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mem leak Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | chrome/browser/autofill/autofill_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/renderer/aw_content_renderer_client.cc
diff --git a/android_webview/renderer/aw_content_renderer_client.cc b/android_webview/renderer/aw_content_renderer_client.cc
index 5114d0f72ee2b3aeb18badb02cb7f1c437bc46db..24349cdd9a00387da9f84c3362e15d73c2aa419a 100644
--- a/android_webview/renderer/aw_content_renderer_client.cc
+++ b/android_webview/renderer/aw_content_renderer_client.cc
@@ -133,6 +133,12 @@ void AwContentRendererClient::RenderFrameCreated(
RenderThread::Get()->Send(new AwViewHostMsg_SubFrameCreated(
parent_frame->GetRoutingID(), render_frame->GetRoutingID()));
}
+
+ // TODO(sgurun) do not create a password autofill agent (change
+ // autofill agent to store a weakptr).
+ autofill::PasswordAutofillAgent* password_autofill_agent =
+ new autofill::PasswordAutofillAgent(render_frame);
+ new autofill::AutofillAgent(render_frame, password_autofill_agent, NULL);
}
void AwContentRendererClient::RenderViewCreated(
@@ -140,11 +146,6 @@ void AwContentRendererClient::RenderViewCreated(
AwRenderViewExt::RenderViewCreated(render_view);
new printing::PrintWebViewHelper(render_view);
- // TODO(sgurun) do not create a password autofill agent (change
- // autofill agent to store a weakptr).
- autofill::PasswordAutofillAgent* password_autofill_agent =
- new autofill::PasswordAutofillAgent(render_view);
- new autofill::AutofillAgent(render_view, password_autofill_agent, NULL);
}
bool AwContentRendererClient::HasErrorPage(int http_status_code,
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | chrome/browser/autofill/autofill_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698