Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix cyclical dependency Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index c2ffb4a1dbdc5052a75a2c456d8a57ef08606ae7..f3fa43645bc5c8c5096118cedba52f830b1b9384 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -15,6 +15,7 @@ namespace password_manager {
struct CredentialInfo;
class PasswordFormManager;
+class PasswordManager;
class PasswordManagerDriver;
class PasswordStore;
@@ -89,7 +90,9 @@ class PasswordManagerClient {
// Returns the PasswordStore associated with this instance.
virtual PasswordStore* GetPasswordStore() = 0;
+ // DEPRECATED
// Returns the PasswordManagerDriver instance associated with this instance.
+ // TODO(estade): get rid of this.
virtual PasswordManagerDriver* GetDriver() = 0;
// Returns the probability that the experiment identified by |experiment_name|
@@ -120,6 +123,16 @@ class PasswordManagerClient {
virtual PasswordStore::AuthorizationPromptPolicy GetAuthorizationPromptPolicy(
const autofill::PasswordForm& form);
+ // Returns whether any SSL certificate errors were encountered as a result of
+ // the last page load.
+ virtual bool DidLastPageLoadEncounterSSLErrors();
+
+ // If this browsing session should not be persisted.
+ virtual bool IsOffTheRecord();
+
+ // FIXME
vabr (Chromium) 2014/11/14 14:46:55 I don't understand -- what should be fixed here? A
Evan Stade 2014/11/14 19:19:00 this is a placeholder for a better comment
+ virtual PasswordManager* GetPasswordManager();
+
private:
DISALLOW_COPY_AND_ASSIGN(PasswordManagerClient);
};

Powered by Google App Engine
This is Rietveld 408576698