components/autofill/core/common/save_password_progress_logger.cc - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix merge fallout, android_webview Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/aw_autofill_client.cc ('K') | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index 7c7be9773e290535ea53cec88918c5b22f430a14..9c85864b1c18577a08d22f69ed29bd76a33c13db 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -113,8 +113,6 @@ std::string GetStringFromID(SavePasswordProgressLogger::StringID id) {

return "Submitted password replaced with the provisionally saved one";

case SavePasswordProgressLogger::STRING_DID_START_PROVISIONAL_LOAD_METHOD:

return "PasswordAutofillAgent::DidStartProvisionalLoad";

- case SavePasswordProgressLogger::STRING_FORM_FRAME_EQ_FRAME:

- return "form_frame == frame";

case SavePasswordProgressLogger::STRING_FRAME_NOT_MAIN_FRAME:

return "|frame| is not the main frame";

case SavePasswordProgressLogger::STRING_PROVISIONALLY_SAVED_FORM_FOR_FRAME: