components/password_manager/content/browser/content_credential_manager_dispatcher.h - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher.h

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self review Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/password_manager/content/browser/BUILD.gn ('k') | components/password_manager/content/browser/content_credential_manager_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_credential_manager_dispatcher.h

diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher.h b/components/password_manager/content/browser/content_credential_manager_dispatcher.h

index 195cbe0d7f6c84713a202f08f599a37e467df44b..1bee1a9c01e7025edb320909394f7e3c79b0b446 100644

--- a/components/password_manager/content/browser/content_credential_manager_dispatcher.h

+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher.h

@@ -24,6 +24,7 @@ namespace password_manager {

class CredentialManagerPasswordFormManager;

class PasswordManagerClient;

+class PasswordManagerDriver;

class PasswordStore;

struct CredentialInfo;

@@ -56,10 +57,16 @@ class ContentCredentialManagerDispatcher : public CredentialManagerDispatcher,

void OnGetPasswordStoreResults(

const std::vector<autofill::PasswordForm*>& results) override;

+ // For testing only.

+ void set_password_manager_driver(PasswordManagerDriver* driver) {

+ driver_ = driver;

+ }

private:

PasswordStore* GetPasswordStore();

PasswordManagerClient* client_;

+ PasswordManagerDriver* driver_;

scoped_ptr<CredentialManagerPasswordFormManager> form_manager_;

// When 'OnRequestCredential' is called, it in turn calls out to the