Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: components/autofill/content/renderer/page_click_tracker.h

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update tests some more Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/page_click_tracker.h
diff --git a/components/autofill/content/renderer/page_click_tracker.h b/components/autofill/content/renderer/page_click_tracker.h
index 7849b902344b257247d68071297992bdb238f9a7..0bcc0f6299b1a06f21bf5dbe248c311f0c25a834 100644
--- a/components/autofill/content/renderer/page_click_tracker.h
+++ b/components/autofill/content/renderer/page_click_tracker.h
@@ -23,7 +23,8 @@ class PageClickListener;
// This is useful for password/form autofill where we want to trigger a
// suggestion popup when a text input is clicked.
//
-// There is one PageClickTracker per RenderView.
+// There is one PageClickTracker per AutofillAgent.
+// TODO(estade): migrate to content::RenderFrameObserver.
class PageClickTracker : public content::RenderViewObserver {
public:
// The |listener| will be notified when an element is clicked. It must
@@ -34,6 +35,7 @@ class PageClickTracker : public content::RenderViewObserver {
private:
// RenderView::Observer implementation.
+ void OnDestruct() override;
void DidHandleMouseEvent(const blink::WebMouseEvent& event) override;
void DidHandleGestureEvent(const blink::WebGestureEvent& event) override;
void FocusedNodeChanged(const blink::WebNode& node) override;

Powered by Google App Engine
This is Rietveld 408576698